Bug 229012 - WebKit2 can only have one active navigation policy check for a given frame
Summary: WebKit2 can only have one active navigation policy check for a given frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-11 13:34 PDT by Chris Dumez
Modified: 2021-08-23 08:02 PDT (History)
9 users (show)

See Also:

Attachments
WIP patch (10.67 KB, patch)
2021-08-11 13:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP patch (7.19 KB, patch)
2021-08-11 13:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.31 KB, patch)
2021-08-11 14:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-08-11 13:34:23 PDT 
WebKit2 can only have one active policy decision for a given frame. This is causing some failures / timeouts in WPT tests, in WebKit2 only.
Comment 1 Chris Dumez 2021-08-11 13:35:49 PDT 
Created attachment 435370 [details]
WIP patch
Comment 2 Chris Dumez 2021-08-11 13:38:11 PDT 
Created attachment 435371 [details]
WIP patch
Comment 3 Chris Dumez 2021-08-11 14:31:26 PDT 
Created attachment 435376 [details]
Patch
Comment 4 Chris Dumez 2021-08-11 15:39:31 PDT 
Comment on attachment 435376 [details]
Patch

Setting review flag to get a review but cq- because I will delay landing this patch until it is safe to do so.
Comment 5 youenn fablet 2021-08-13 00:15:14 PDT 
Comment on attachment 435376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435376&action=review

> Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221
>  uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler)

Would be nice to use a PolicyListenerIdentifier.
Comment 6 Radar WebKit Bug Importer 2021-08-18 13:35:27 PDT 
<rdar://problem/82092066>
Comment 7 Chris Dumez 2021-08-23 07:55:21 PDT 
(In reply to youenn fablet from comment #5)
> Comment on attachment 435376 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435376&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebFrame.cpp:221
> >  uint64_t WebFrame::setUpWillSubmitFormListener(CompletionHandler<void()>&& completionHandler)
> 
> Would be nice to use a PolicyListenerIdentifier.

I agree but I'll follow-up for the refactoring.
Comment 8 Chris Dumez 2021-08-23 08:02:40 PDT 
Comment on attachment 435376 [details]
Patch

Clearing flags on attachment: 435376

Committed r281445 (240828@main): <https://commits.webkit.org/240828@main>
Comment 9 Chris Dumez 2021-08-23 08:02:43 PDT 
All reviewed patches have been landed.  Closing bug.