Bug 228987 – ANGLE Cocoa compiles contents of ContextEAGL on mac

• Status: RESOLVED
• Resolution: FIXED
• Component: ANGLE

[Kimmo Kinnunen]

ANGLE Cocoa compiles contents ContextEAGL on Mac, guards missing

[Kimmo Kinnunen]

Created attachment 435330 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

Comment on attachment 435330 [details]
Patch

Looks good to me. We need to be sure to either upstream this or avoid losing it while rolling ANGLE back down into WebKit. Do you want to point to this on https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ?

r+

[Dean Jackson]

Comment on attachment 435330 [details]
Patch

Before we can land this - please check that it doesn't break Catalyst.

[Kimmo Kinnunen]

Upstreaming bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=6271

[Kimmo Kinnunen]

(In reply to Dean Jackson from comment #4)
> Comment on attachment 435330 [details]
> Patch
> 
> Before we can land this - please check that it doesn't break Catalyst.

I checked that it compiles on Catalyst. The Catalyst doesn't yet have tests so I didn't spend time building an app to verify that WebGL works. 

The condition itself is same as in other files. 

Before, the condition was in 4 EAGL files and missing in 1 EAGL file.
After, the condition was in 5 EAGL files.

Based on this, I'll land.

[EWS]

Committed r280962 (240468@main): <https://commits.webkit.org/240468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435330 [details].

[Radar WebKit Bug Importer]

<rdar://problem/81844871>