Bug 228987 - ANGLE Cocoa compiles contents of ContextEAGL on mac
Summary: ANGLE Cocoa compiles contents of ContextEAGL on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-11 02:20 PDT by Kimmo Kinnunen
Modified: 2021-08-12 06:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2021-08-11 02:22 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-08-11 02:20:43 PDT
ANGLE Cocoa compiles contents ContextEAGL on Mac, guards missing
Comment 1 Kimmo Kinnunen 2021-08-11 02:22:35 PDT
Created attachment 435330 [details]
Patch
Comment 2 EWS Watchlist 2021-08-11 02:23:25 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-08-11 12:30:13 PDT
Comment on attachment 435330 [details]
Patch

Looks good to me. We need to be sure to either upstream this or avoid losing it while rolling ANGLE back down into WebKit. Do you want to point to this on https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ?

r+
Comment 4 Dean Jackson 2021-08-11 13:15:26 PDT
Comment on attachment 435330 [details]
Patch

Before we can land this - please check that it doesn't break Catalyst.
Comment 5 Kimmo Kinnunen 2021-08-11 23:29:28 PDT
Upstreaming bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=6271
Comment 6 Kimmo Kinnunen 2021-08-12 05:57:48 PDT
(In reply to Dean Jackson from comment #4)
> Comment on attachment 435330 [details]
> Patch
> 
> Before we can land this - please check that it doesn't break Catalyst.

I checked that it compiles on Catalyst. The Catalyst doesn't yet have tests so I didn't spend time building an app to verify that WebGL works. 

The condition itself is same as in other files. 

Before, the condition was in 4 EAGL files and missing in 1 EAGL file.
After, the condition was in 5 EAGL files.

Based on this, I'll land.
Comment 7 EWS 2021-08-12 06:01:34 PDT
Committed r280962 (240468@main): <https://commits.webkit.org/240468@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435330 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-12 06:02:19 PDT
<rdar://problem/81844871>