Bug 228986 - ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly
Summary: ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-11 02:01 PDT by Kimmo Kinnunen
Modified: 2021-08-12 03:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (77.05 KB, patch)
2021-08-11 02:06 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-08-11 02:01:19 PDT 
ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly

These are not used in ANGLE Cocoa and as such should not be compiled.
Comment 1 Kimmo Kinnunen 2021-08-11 02:06:01 PDT 
Created attachment 435329 [details]
Patch
Comment 2 EWS Watchlist 2021-08-11 02:06:45 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-08-11 11:14:46 PDT 
Comment on attachment 435329 [details]
Patch

Looks good to me if everything still builds and runs. While initially integrating ANGLE into WebKit I had difficulty compiling out some of these sources because doing so would have required code changes, so good to see you made it work. r+
Comment 4 EWS 2021-08-12 03:16:29 PDT 
Committed r280959 (240465@main): <https://commits.webkit.org/240465@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435329 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-12 03:17:19 PDT 
<rdar://problem/81838585>