Bug 228965 – Meta HTTP refresh should not navigate if document has sandboxed automatic features browsing context flag set

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Meta HTTP refresh should not navigate if document has sandboxed automatic features browsing context flag set:
- https://html.spec.whatwg.org/multipage/semantics.html#shared-declarative-refresh-steps (Step 13)

Firefox and Chrome already behave this way.

[Chris Dumez]

Created attachment 435281 [details]
Patch

[Darin Adler]

Comment on attachment 435281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435281&action=review

> Source/WebCore/loader/NavigationScheduler.cpp:186
> +            if (auto* document = frame.document()) {
> +                if (document->isSandboxed(SandboxAutomaticFeatures)) {

Rather than nesting, I like this style:

    if (auto document = frame.document(); document && document->isSandboxed(SandboxAutomaticFeatures) {

[Darin Adler]

Comment on attachment 435281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435281&action=review

>> Source/WebCore/loader/NavigationScheduler.cpp:186
>> +                if (document->isSandboxed(SandboxAutomaticFeatures)) {
> 
> Rather than nesting, I like this style:
> 
>     if (auto document = frame.document(); document && document->isSandboxed(SandboxAutomaticFeatures) {

Not saying you must change this, just telling you the style I prefer.

[Chris Dumez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 435281 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435281&action=review
> 
> >> Source/WebCore/loader/NavigationScheduler.cpp:186
> >> +                if (document->isSandboxed(SandboxAutomaticFeatures)) {
> > 
> > Rather than nesting, I like this style:
> > 
> >     if (auto document = frame.document(); document && document->isSandboxed(SandboxAutomaticFeatures) {
> 
> Not saying you must change this, just telling you the style I prefer.

Oh, indeed. It is nicer and will make the update. My brain just hasn't adjusted to the new C++ syntax yet :)

[Chris Dumez]

Created attachment 435302 [details]
Patch

[EWS]

Committed r280870 (240409@main): <https://commits.webkit.org/240409@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435302 [details].

[Radar WebKit Bug Importer]

<rdar://problem/81766558>