Bug 228947 – Implement SFrameTransform error handling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Implement SFrameTransform error handling

[youenn fablet]

Created attachment 435253 [details]
Patch

[youenn fablet]

Created attachment 435262 [details]
Patch

[youenn fablet]

Comment on attachment 435262 [details]
Patch

bot error is unrelated

[Eric Carlson]

Comment on attachment 435262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435262&action=review

> Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:118
> +static std::optional<Vector<uint8_t>> processFrame(const uint8_t* data, size_t size, RTCRtpSFrameTransformer& transformer, ScriptExecutionContextIdentifier identifier, const WeakPtr<RTCRtpSFrameTransform>& weakTransform)

It might be worth using Span here and the other places you pass around { uint8_t*, size_t } in these classes.

[youenn fablet]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 435262 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435262&action=review
> 
> > Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:118
> > +static std::optional<Vector<uint8_t>> processFrame(const uint8_t* data, size_t size, RTCRtpSFrameTransformer& transformer, ScriptExecutionContextIdentifier identifier, const WeakPtr<RTCRtpSFrameTransform>& weakTransform)
> 
> It might be worth using Span here and the other places you pass around {
> uint8_t*, size_t } in these classes.

Good idea, I'll do the refactoring in a follow-up as this entails changes to transformer and frame classes.

[EWS]

Committed r280958 (240464@main): <https://commits.webkit.org/240464@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435262 [details].

[Radar WebKit Bug Importer]

<rdar://problem/81837525>

[youenn fablet]

> Good idea, I'll do the refactoring in a follow-up as this entails changes to
> transformer and frame classes.

https://bugs.webkit.org/show_bug.cgi?id=229029