typo in LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html

[Tony Chang]

This test tries to call layoutTestController.setUseDashboardCompatibilityMode, but actually calls layoutTestController.setUseDashboardCompatiblityMode (there's a missing 'i').  The baseline also has red as a result.

Patch coming with new pixel baseline...

[Tony Chang]

Created attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path

 LayoutTests/ChangeLog                              |   14 ++++++++++++++
 .../fast/canvas/fill-stroke-clip-reset-path.html   |    5 +++--
 .../fill-stroke-clip-reset-path-expected.checksum  |    2 +-
 .../fill-stroke-clip-reset-path-expected.png       |  Bin 25099 -> 25179 bytes
 4 files changed, 18 insertions(+), 3 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path

LGTM.  WebKit style says single line ifs don't have { } (I think that holds true even in JS).

[Alexey Proskuryakov]

The patch doesn't include diffs for results:
Binary files a/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png and b/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png differ

Our svn-create-patch script encodes binary files in patches, and svn-apply/svn-unapply scripts support that.

[Tony Chang]

Created attachment 26740 [details]
svn, not git

Updated to not add {} and include the binary diff.

[Darin Adler]

Comment on attachment 26740 [details]
svn, not git

Looks good. r=me

[Darin Fisher (:fishd, Google)]

http://trac.webkit.org/changeset/40388