Bug 22894 - typo in LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html
Summary: typo in LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 16:40 PST by Tony Chang
Modified: 2009-01-29 16:48 PST (History)
0 users

See Also:


Attachments
[1/1] Fix typo in fill-stroke-clip-reset-path (2.54 KB, patch)
2008-12-16 16:59 PST, Tony Chang
eric: review+
Details | Formatted Diff | Diff
svn, not git (35.42 KB, patch)
2009-01-14 17:56 PST, Tony Chang
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-12-16 16:40:04 PST
This test tries to call layoutTestController.setUseDashboardCompatibilityMode, but actually calls layoutTestController.setUseDashboardCompatiblityMode (there's a missing 'i').  The baseline also has red as a result.

Patch coming with new pixel baseline...
Comment 1 Tony Chang 2008-12-16 16:59:51 PST
Created attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path

 LayoutTests/ChangeLog                              |   14 ++++++++++++++
 .../fast/canvas/fill-stroke-clip-reset-path.html   |    5 +++--
 .../fill-stroke-clip-reset-path-expected.checksum  |    2 +-
 .../fill-stroke-clip-reset-path-expected.png       |  Bin 25099 -> 25179 bytes
 4 files changed, 18 insertions(+), 3 deletions(-)
Comment 2 Eric Seidel (no email) 2009-01-06 14:01:52 PST
Comment on attachment 26078 [details]
[1/1] Fix typo in fill-stroke-clip-reset-path

LGTM.  WebKit style says single line ifs don't have { } (I think that holds true even in JS).
Comment 3 Alexey Proskuryakov 2009-01-11 01:55:50 PST
The patch doesn't include diffs for results:
Binary files a/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png and b/LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png differ

Our svn-create-patch script encodes binary files in patches, and svn-apply/svn-unapply scripts support that.
Comment 4 Tony Chang 2009-01-14 17:56:35 PST
Created attachment 26740 [details]
svn, not git

Updated to not add {} and include the binary diff.
Comment 5 Darin Adler 2009-01-14 18:03:42 PST
Comment on attachment 26740 [details]
svn, not git

Looks good. r=me
Comment 6 Darin Fisher (:fishd, Google) 2009-01-29 16:48:42 PST
http://trac.webkit.org/changeset/40388