Bug 228936 - Notify accessibility that WebProcess is suspended when in process cache.
Summary: Notify accessibility that WebProcess is suspended when in process cache.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-09 18:16 PDT by Andres Gonzalez
Modified: 2021-08-10 14:37 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.13 KB, patch)
2021-08-09 20:17 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2021-08-09 20:42 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2021-08-10 11:32 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-08-09 18:16:48 PDT 
Notify accessibility that WebProcess is suspended when in process cache.
Comment 1 Andres Gonzalez 2021-08-09 19:26:37 PDT 
rdar://80911502
Comment 2 Andres Gonzalez 2021-08-09 20:17:03 PDT 
Created attachment 435237 [details]
Patch
Comment 3 Andres Gonzalez 2021-08-09 20:42:59 PDT 
Created attachment 435239 [details]
Patch
Comment 4 Chris Dumez 2021-08-10 08:19:10 PDT 
Comment on attachment 435239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435239&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:632
> +    IPC::AccessibilityProcessSuspendedNotification(isInProcessCache);

We may want to get rid of the AccessibilityProcessSuspendedNotification() that exists in WebProcessCocoa.mm now that we can call the one in IPC::Connection.
Comment 5 Andres Gonzalez 2021-08-10 11:32:42 PDT 
Created attachment 435275 [details]
Patch
Comment 6 Andres Gonzalez 2021-08-10 11:35:37 PDT 
(In reply to Chris Dumez from comment #4)
> Comment on attachment 435239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435239&action=review
> 
> > Source/WebKit/WebProcess/WebProcess.cpp:632
> > +    IPC::AccessibilityProcessSuspendedNotification(isInProcessCache);
> 
> We may want to get rid of the AccessibilityProcessSuspendedNotification()
> that exists in WebProcessCocoa.mm now that we can call the one in
> IPC::Connection.

Done. Thanks!
Comment 7 EWS 2021-08-10 14:37:27 PDT 
Committed r280865 (240405@main): <https://commits.webkit.org/240405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435275 [details].