imported/w3c/web-platform-tests/cors/304.htm [ Failure ] imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/basic/conditional-get.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-default.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-default.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-force-cache.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/api/request/request-cache-reload.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/304-update.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/304-update.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/freshness.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/freshness.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/heuristic.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/heuristic.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/invalidate.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/invalidate.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/split-cache.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/status.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/status.any.worker.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/vary.any.html [ Failure ] imported/w3c/web-platform-tests/fetch/http-cache/vary.any.worker.html [ Failure ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache.tentative.html [ Failure ] These 25 tests began failing after the changes in https://trac.webkit.org/changeset/280726/webkit Build: https://build.webkit.org/#/builders/48/builds/4449 Results: https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r280726%20(4449)/results.html
<rdar://problem/81715332>
Also this API tests is failing sense r280726 TestWebKitAPI.AudioRoutingArbitration.Updating History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.AudioRoutingArbitration.Updating /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:152 Expected: (arbitrationUpdateTime) < ([webView _audioRoutingArbitrationUpdateTime]), actual: 1.62861e+09 vs 1.62861e+09 Arbitration was not updated
(In reply to Truitt Savell from comment #2) > Also this API tests is failing sense r280726 > > TestWebKitAPI.AudioRoutingArbitration.Updating > > History: > https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI. > AudioRoutingArbitration.Updating > > /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/ > WebKitCocoa/AudioRoutingArbitration.mm:152 > Expected: (arbitrationUpdateTime) < ([webView > _audioRoutingArbitrationUpdateTime]), actual: 1.62861e+09 vs 1.62861e+09 > Arbitration was not updated File bug 228966 to track this failure.
Created attachment 435282 [details] Patch
Created attachment 435305 [details] Update comments
Committed r280884 (240421@main): <https://commits.webkit.org/240421@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435305 [details].
Reopen this bug because the issue has not been resolved yet.
Created attachment 435340 [details] Patch
Created attachment 435402 [details] Patch for landing - beefed up change log
Not sure why AS EWS bot is not happy with the patch it used to be happy with yesterday. Let's land it and I'll revert it if builders are not happy with it.
Created attachment 435405 [details] Rebasing
Committed r280961 (240467@main): <https://commits.webkit.org/240467@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435405 [details].
Comment on attachment 435405 [details] Rebasing View in context: https://bugs.webkit.org/attachment.cgi?id=435405&action=review > Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52 > +#if PLATFORM(MAC) Does this do the right thing for macCatalyst?
Comment on attachment 435405 [details] Rebasing View in context: https://bugs.webkit.org/attachment.cgi?id=435405&action=review >> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52 >> +#if PLATFORM(MAC) > > Does this do the right thing for macCatalyst? Confirmed with Tim. This patch is correct. macCatalyst will use the #else branch as expected.
(In reply to Peng Liu from comment #14) > Comment on attachment 435405 [details] > Rebasing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435405&action=review > > >> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52 > >> +#if PLATFORM(MAC) > > > > Does this do the right thing for macCatalyst? > > Confirmed with Tim. This patch is correct. macCatalyst will use the #else > branch as expected. "Correct" is a strong word :) But it doesn't /matter/.
(In reply to Tim Horton from comment #15) > (In reply to Peng Liu from comment #14) > > Comment on attachment 435405 [details] > > Rebasing > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=435405&action=review > > > > >> Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm:52 > > >> +#if PLATFORM(MAC) > > > > > > Does this do the right thing for macCatalyst? > > > > Confirmed with Tim. This patch is correct. macCatalyst will use the #else > > branch as expected. > > "Correct" is a strong word :) But it doesn't /matter/. (except for local builds)