Bug 228894 - [:has() pseudo-class] Basic support
Summary: [:has() pseudo-class] Basic support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 227702
  Show dependency tree / graph
 
Reported: 2021-08-07 03:17 PDT by Antti Koivisto
Modified: 2021-08-19 22:15 PDT (History)
9 users (show)

See Also:

Attachments
patch (51.93 KB, patch)
2021-08-07 03:32 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-08-07 03:17:44 PDT 
Basic support for https://drafts.csswg.org/selectors/#has-pseudo
Comment 1 Antti Koivisto 2021-08-07 03:32:46 PDT 
Created attachment 435126 [details]
patch
Comment 2 Simon Fraser (smfr) 2021-08-08 08:54:15 PDT 
Comment on attachment 435126 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review

> Source/WebCore/css/parser/CSSSelectorParser.cpp:286
> +        if (hasScopePseudoClass(*end))

Is end always non-null here?
Comment 3 Antti Koivisto 2021-08-08 09:01:46 PDT 
Comment on attachment 435126 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review

>> Source/WebCore/css/parser/CSSSelectorParser.cpp:286
>> +        if (hasScopePseudoClass(*end))
> 
> Is end always non-null here?

yeah, the while() condition checks it
Comment 4 Radar WebKit Bug Importer 2021-08-14 03:18:19 PDT 
<rdar://problem/81933618>
Comment 5 EWS 2021-08-19 22:15:55 PDT 
Committed r281295 (240719@main): <https://commits.webkit.org/240719@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435126 [details].