Bug 228882 - [LFC][Integration] HTMLTextFormControlElement should use the inline iterator to collect content for wrap=hard
Summary: [LFC][Integration] HTMLTextFormControlElement should use the inline iterator ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-06 18:26 PDT by zalan
Modified: 2021-08-20 19:45 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.96 KB, patch)
2021-08-06 18:45 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.29 KB, patch)
2021-08-20 06:04 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (8.28 KB, patch)
2021-08-20 14:17 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-08-06 18:26:41 PDT 
see HTMLTextFormControlElement::valueWithHardLineBreaks
Comment 1 zalan 2021-08-06 18:45:34 PDT 
Created attachment 435105 [details]
Patch
Comment 2 Antti Koivisto 2021-08-07 06:02:29 PDT 
Comment on attachment 435105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review

> Source/WebCore/html/HTMLTextFormControlElement.cpp:709
> +        for (; currentLine; currentLine = currentLine.traverseNext()) {

no need for "currentLine =", traverseNext mutates the iterator.
Comment 3 Antti Koivisto 2021-08-07 06:03:59 PDT 
Comment on attachment 435105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435105&action=review

> Source/WebCore/html/HTMLTextFormControlElement.cpp:717
> +                currentLine = currentLine.traverseNext();

Same here
Comment 4 Radar WebKit Bug Importer 2021-08-13 18:27:27 PDT 
<rdar://problem/81924585>
Comment 5 zalan 2021-08-20 06:04:07 PDT 
Created attachment 435978 [details]
Patch
Comment 6 zalan 2021-08-20 14:17:49 PDT 
Created attachment 436026 [details]
Patch
Comment 7 EWS 2021-08-20 19:45:05 PDT 
Committed r281358 (240773@main): <https://commits.webkit.org/240773@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436026 [details].