Bug 22888 - Move TransformOperations files (e.g., TranslateTransformOperation.(cpp,h} to platform
Summary: Move TransformOperations files (e.g., TranslateTransformOperation.(cpp,h} to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 14:59 PST by Chris Marrin
Modified: 2008-12-18 13:08 PST (History)
1 user (show)

See Also:


Attachments
Patch (126.29 KB, patch)
2008-12-16 16:13 PST, Chris Marrin
no flags Details | Formatted Diff | Diff
Replacement patch with a couple more moved files (171.68 KB, patch)
2008-12-18 10:26 PST, Chris Marrin
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2008-12-16 14:59:24 PST
To avoid future dependency issues, all the TransformOperations related files need to be moved to platform. This is an easy move since they currently don't depend on anything outside platform. I will move these to platform/graphics, which is where AffineTransform lives today. I will put them into a separate 'transforms' subdir to avoid polluting the main dir. I will move AffineTransform here as well.
Comment 1 Chris Marrin 2008-12-16 16:13:27 PST
Created attachment 26077 [details]
Patch
Comment 2 Chris Marrin 2008-12-18 10:00:23 PST
Comment on attachment 26077 [details]
Patch

I need to add a couple more files
Comment 3 Chris Marrin 2008-12-18 10:26:35 PST
Created attachment 26123 [details]
Replacement patch with a couple more moved files
Comment 4 Dave Hyatt 2008-12-18 11:55:02 PST
Comment on attachment 26123 [details]
Replacement patch with a couple more moved files

r=me
Comment 5 Chris Marrin 2008-12-18 13:08:25 PST
Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.xcodeproj/project.pbxproj
Adding         WebCore/platform/animation
Adding         WebCore/platform/animation/Animation.cpp
Adding         WebCore/platform/animation/Animation.h
Adding         WebCore/platform/animation/AnimationList.cpp
Adding         WebCore/platform/animation/AnimationList.h
Adding         WebCore/platform/animation/TimingFunction.h
Deleting       WebCore/platform/graphics/AffineTransform.cpp
Deleting       WebCore/platform/graphics/AffineTransform.h
Adding         WebCore/platform/graphics/transforms
Adding         WebCore/platform/graphics/transforms/AffineTransform.cpp
Adding         WebCore/platform/graphics/transforms/AffineTransform.h
Adding         WebCore/platform/graphics/transforms/IdentityTransformOperation.h
Adding         WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp
Adding         WebCore/platform/graphics/transforms/MatrixTransformOperation.h
Adding         WebCore/platform/graphics/transforms/RotateTransformOperation.cpp
Adding         WebCore/platform/graphics/transforms/RotateTransformOperation.h
Adding         WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp
Adding         WebCore/platform/graphics/transforms/ScaleTransformOperation.h
Adding         WebCore/platform/graphics/transforms/SkewTransformOperation.cpp
Adding         WebCore/platform/graphics/transforms/SkewTransformOperation.h
Adding         WebCore/platform/graphics/transforms/TransformOperation.h
Adding         WebCore/platform/graphics/transforms/TransformOperations.cpp
Adding         WebCore/platform/graphics/transforms/TransformOperations.h
Adding         WebCore/platform/graphics/transforms/TranslateTransformOperation.cpp
Adding         WebCore/platform/graphics/transforms/TranslateTransformOperation.h
Deleting       WebCore/rendering/style/Animation.cpp
Deleting       WebCore/rendering/style/Animation.h
Deleting       WebCore/rendering/style/AnimationList.cpp
Deleting       WebCore/rendering/style/AnimationList.h
Deleting       WebCore/rendering/style/IdentityTransformOperation.h
Deleting       WebCore/rendering/style/MatrixTransformOperation.cpp
Deleting       WebCore/rendering/style/MatrixTransformOperation.h
Deleting       WebCore/rendering/style/RotateTransformOperation.cpp
Deleting       WebCore/rendering/style/RotateTransformOperation.h
Deleting       WebCore/rendering/style/ScaleTransformOperation.cpp
Deleting       WebCore/rendering/style/ScaleTransformOperation.h
Deleting       WebCore/rendering/style/SkewTransformOperation.cpp
Deleting       WebCore/rendering/style/SkewTransformOperation.h
Deleting       WebCore/rendering/style/TimingFunction.h
Deleting       WebCore/rendering/style/TransformOperation.h
Deleting       WebCore/rendering/style/TransformOperations.cpp
Deleting       WebCore/rendering/style/TransformOperations.h
Deleting       WebCore/rendering/style/TranslateTransformOperation.cpp
Deleting       WebCore/rendering/style/TranslateTransformOperation.h
Transmitting file data .......................
Committed revision 39378.