Bug 228878 – CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const

[Kate Cheney]

Created attachment 435093 [details]
Patch

[Kate Cheney]

rdar://60147231

[Brent Fulgham]

Comment on attachment 435093 [details]
Patch

R=me

[Brent Fulgham]

Comment on attachment 435093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review

> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143
> +        return result;

Should we log anything here? I assume JsonWebKey initialized these values appropriately?

[Kate Cheney]

Comment on attachment 435093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review

>> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143
>> +        return result;
> 
> Should we log anything here? I assume JsonWebKey initialized these values appropriately?

The exportData() function logs anytime it returns nullptr, so I think extra logging here would be unnecessary. It probably is a good idea to investigate why CCRSAGetKeyComponents is failing sometimes and causing rsaComponents to be null, though.

[EWS]

Committed r280747 (240333@main): <https://commits.webkit.org/240333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435093 [details].

[Kate Cheney]

Layout test failures are in web animations and seem super unrelated.