Bug 228878 - CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const
Summary: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::Crypt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-06 14:59 PDT by Kate Cheney
Modified: 2021-08-07 04:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2021-08-06 15:01 PDT, Kate Cheney
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-08-06 14:59:28 PDT
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const
Comment 1 Kate Cheney 2021-08-06 15:01:19 PDT
Created attachment 435093 [details]
Patch
Comment 2 Kate Cheney 2021-08-06 15:01:30 PDT
rdar://60147231
Comment 3 Brent Fulgham 2021-08-06 17:32:18 PDT
Comment on attachment 435093 [details]
Patch

R=me
Comment 4 Brent Fulgham 2021-08-06 17:33:58 PDT
Comment on attachment 435093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review

> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143
> +        return result;

Should we log anything here? I assume JsonWebKey initialized these values appropriately?
Comment 5 Kate Cheney 2021-08-06 17:47:33 PDT
Comment on attachment 435093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review

>> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143
>> +        return result;
> 
> Should we log anything here? I assume JsonWebKey initialized these values appropriately?

The exportData() function logs anytime it returns nullptr, so I think extra logging here would be unnecessary. It probably is a good idea to investigate why CCRSAGetKeyComponents is failing sometimes and causing rsaComponents to be null, though.
Comment 6 EWS 2021-08-06 18:16:36 PDT
Committed r280747 (240333@main): <https://commits.webkit.org/240333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435093 [details].
Comment 7 Kate Cheney 2021-08-06 20:04:42 PDT
Layout test failures are in web animations and seem super unrelated.