WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22886
JIT doesn't compile on x86-64. Make it do so.
https://bugs.webkit.org/show_bug.cgi?id=22886
Summary
JIT doesn't compile on x86-64. Make it do so.
Gavin Barraclough
Reported
2008-12-16 14:55:13 PST
*Compile*, not run, don't get too excited folks.
Attachments
The patch
(37.90 KB, patch)
2008-12-16 15:28 PST
,
Gavin Barraclough
zwarich
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2008-12-16 15:28:44 PST
Created
attachment 26074
[details]
The patch There is something slightly weird going on in JSImmediate.h, but I'm not changing current behaviour, & I've raised a separate bug to explore this. Will have a quick look at the problem this afternoon.
https://bugs.webkit.org/show_bug.cgi?id=22889
Cameron Zwarich (cpst)
Comment 2
2008-12-16 15:41:58 PST
Comment on
attachment 26074
[details]
The patch
> repathcing property access code
There is a typo in "repathcing". I think you should include a description of what you did in Interpreter.cpp, since diff seems to have hated you so much.
> // DEBUG ME!: Why does the result of this need be a 64-bit value?
We use FIXME to identify issues that need to be reexamined in the future. Using the same thing everywhere makes it easier to search for. Other than that, r=me.
Gavin Barraclough
Comment 3
2008-12-16 16:03:48 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/AssemblerBuffer.h Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/interpreter/Interpreter.cpp Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITPropertyAccess.cpp Sending JavaScriptCore/runtime/JSImmediate.h Transmitting file data ......... Committed revision 39342.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug