Bug 22886 – JIT doesn't compile on x86-64. Make it do so.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

*Compile*, not run, don't get too excited folks.

[Gavin Barraclough]

Created attachment 26074 [details]
The patch

There is something slightly weird going on in JSImmediate.h, but I'm not changing current behaviour, & I've raised a separate bug to explore this.  Will have a quick look at the problem this afternoon.

https://bugs.webkit.org/show_bug.cgi?id=22889

[Cameron Zwarich (cpst)]

Comment on attachment 26074 [details]
The patch

> repathcing property access code

There is a typo in "repathcing".

I think you should include a description of what you did in Interpreter.cpp, since diff seems to have hated you so much.

> // DEBUG ME!: Why does the result of this need be a 64-bit value?

We use FIXME to identify issues that need to be reexamined in the future. Using the same thing everywhere makes it easier to search for.

Other than that, r=me.

[Gavin Barraclough]

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/AssemblerBuffer.h
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/interpreter/Interpreter.cpp
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JITCall.cpp
Sending        JavaScriptCore/jit/JITPropertyAccess.cpp
Sending        JavaScriptCore/runtime/JSImmediate.h
Transmitting file data .........
Committed revision 39342.