Bug 228852 - Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation
Summary: Add deduction guide to RetainPtr, use constexpr a bit more, and streamline th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-05 18:12 PDT by Darin Adler
Modified: 2021-08-12 08:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (16.50 KB, patch)
2021-08-05 18:21 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-08-05 18:12:12 PDT 
Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation
Comment 1 Darin Adler 2021-08-05 18:21:16 PDT 
Created attachment 435044 [details]
Patch
Comment 2 Darin Adler 2021-08-09 15:33:21 PDT 
Comment on attachment 435044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435044&action=review

> Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:230
>      _findReplyCallbacks.append([progress, copiedResultCollector] (NSArray *matches, bool didWrap) {

Just realized this should move the progress in, instead of copying.
Comment 3 EWS 2021-08-11 19:08:15 PDT 
Committed r280952 (240458@main): <https://commits.webkit.org/240458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435044 [details].
Comment 4 Radar WebKit Bug Importer 2021-08-11 19:09:18 PDT 
<rdar://problem/81824803>
Comment 5 Chris Dumez 2021-08-12 08:54:31 PDT 
Follow-up build fix: https://commits.webkit.org/240475@main