RESOLVED FIXED 228852
Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation 
https://bugs.webkit.org/show_bug.cgi?id=228852
Summary Add deduction guide to RetainPtr, use constexpr a bit more, and streamline th...
Darin Adler
Reported 2021-08-05 18:12:12 PDT
Add deduction guide to RetainPtr, use constexpr a bit more, and streamline the implementation
Attachments
Patch (16.50 KB, patch)
2021-08-05 18:21 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-08-05 18:21:16 PDT
Created attachment 435044 [details] Patch
Darin Adler
Comment 2 2021-08-09 15:33:21 PDT
Comment on attachment 435044 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435044&action=review > Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:230 > _findReplyCallbacks.append([progress, copiedResultCollector] (NSArray *matches, bool didWrap) { Just realized this should move the progress in, instead of copying.
EWS
Comment 3 2021-08-11 19:08:15 PDT
Committed r280952 (240458@main): <https://commits.webkit.org/240458@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435044 [details].
Radar WebKit Bug Importer
Comment 4 2021-08-11 19:09:18 PDT
<rdar://problem/81824803>
Chris Dumez
Comment 5 2021-08-12 08:54:31 PDT
Follow-up build fix: https://commits.webkit.org/240475@main
Note You need to log in before you can comment on or make changes to this bug.