Bug 228832 - Implement no-quirks mode for media/plugin/ua-inline documents
Summary: Implement no-quirks mode for media/plugin/ua-inline documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 244950
Blocks:
  Show dependency treegraph
 
Reported: 2021-08-05 08:59 PDT by Mason Freed
Modified: 2022-09-15 12:34 PDT (History)
24 users (show)

See Also:


Attachments
WIP patch (5.31 KB, patch)
2021-08-27 14:01 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP patch (15.52 KB, patch)
2021-08-27 15:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP patch (15.50 KB, patch)
2021-08-27 16:27 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP patch (14.66 KB, patch)
2021-08-30 09:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
WIP patch (16.16 KB, patch)
2021-08-30 10:26 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mason Freed 2021-08-05 08:59:06 PDT
The spec has recently changed for these document types, to indicate that they should be standards-mode documents instead of quirks-mode documents.

https://github.com/whatwg/html/pull/6745

The implementation should change accordingly.

These three WPTs test some of this behavior:
https://wpt.fyi/results/html/browsers/browsing-the-web/read-media/pageload-video.html
https://wpt.fyi/results/html/browsers/browsing-the-web/read-media/pageload-image.html
https://wpt.fyi/results/html/browsers/browsing-the-web/read-text/load-text-plain.html
Comment 1 Radar WebKit Bug Importer 2021-08-12 09:00:16 PDT
<rdar://problem/81851619>
Comment 2 Chris Dumez 2021-08-27 14:01:35 PDT
Created attachment 436671 [details]
WIP patch
Comment 3 Chris Dumez 2021-08-27 15:51:36 PDT
Created attachment 436686 [details]
WIP patch
Comment 4 Chris Dumez 2021-08-27 16:27:43 PDT
Created attachment 436689 [details]
WIP patch
Comment 5 Chris Dumez 2021-08-30 09:59:35 PDT
Created attachment 436787 [details]
WIP patch
Comment 6 Chris Dumez 2021-08-30 10:26:08 PDT
Created attachment 436791 [details]
WIP patch
Comment 7 Ahmad Saleem 2022-08-10 09:38:23 PDT
From the test cases in Comment 0:

Test 1 - Only Firefox pass this test as of right now.

Test 2 - Only Safari fail this test.

Test 3 - Safari fail one of the test and it is only browsers failing this test. All browsers (Chrome Canary 106 and Firefox Nightly 105) pass all tests.

Just wanted to share updated status. Thanks!
Comment 8 Brent Fulgham 2022-09-12 11:48:47 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4272
Comment 9 EWS 2022-09-15 12:34:55 PDT
Committed 254526@main (fcbca01158eb): <https://commits.webkit.org/254526@main>

Reviewed commits have been landed. Closing PR #4272 and removing active labels.