Bug 228825 - [MSE][GStreamer] Update tracks synchronously
Summary: [MSE][GStreamer] Update tracks synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-05 06:53 PDT by Alicia Boya García
Modified: 2021-08-12 18:19 PDT (History)
13 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2021-08-05 06:54 PDT, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-08-05 06:53:30 PDT 
A mistake introduced with the WebKitMediaSrc v2 patch made the call to
updateTracks() in MediaPlayerPrivateGStreamer asynchronous.

This introduced a subtle race condition in which the "resize" event
may be handled before updateTracks() is called, therefore m_hasVideo
has not yet been set to true, and querying the video size from the
"resize" event handler returns 0x0.

This fixes a timeout flake in media/media-source/media-source-resize.html.
Comment 1 Alicia Boya García 2021-08-05 06:54:26 PDT 
Created attachment 434983 [details]
Patch
Comment 2 EWS 2021-08-09 06:11:02 PDT 
Committed r280775 (240359@main): <https://commits.webkit.org/240359@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434983 [details].