WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
228825
[MSE][GStreamer] Update tracks synchronously
https://bugs.webkit.org/show_bug.cgi?id=228825
Summary
[MSE][GStreamer] Update tracks synchronously
Alicia Boya García
Reported
2021-08-05 06:53:30 PDT
A mistake introduced with the WebKitMediaSrc v2 patch made the call to updateTracks() in MediaPlayerPrivateGStreamer asynchronous. This introduced a subtle race condition in which the "resize" event may be handled before updateTracks() is called, therefore m_hasVideo has not yet been set to true, and querying the video size from the "resize" event handler returns 0x0. This fixes a timeout flake in media/media-source/media-source-resize.html.
Attachments
Patch
(2.06 KB, patch)
2021-08-05 06:54 PDT
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2021-08-05 06:54:26 PDT
Created
attachment 434983
[details]
Patch
EWS
Comment 2
2021-08-09 06:11:02 PDT
Committed
r280775
(
240359@main
): <
https://commits.webkit.org/240359@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 434983
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug