Bug 228816 - MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
Summary: MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not vi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-05 03:09 PDT by youenn fablet
Modified: 2021-08-06 02:16 PDT (History)
17 users (show)

See Also:

Attachments
Patch (16.77 KB, patch)
2021-08-05 03:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (16.76 KB, patch)
2021-08-05 10:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-08-05 03:09:27 PDT 
MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
Comment 1 youenn fablet 2021-08-05 03:10:59 PDT 
<rdar://81077972>
Comment 2 youenn fablet 2021-08-05 03:24:45 PDT 
Created attachment 434974 [details]
Patch
Comment 3 Eric Carlson 2021-08-05 09:38:47 PDT 
Comment on attachment 434974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434974&action=review

> Source/WebCore/ChangeLog:11
> +        We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value.

s/by stopping to call/by not calling/

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611
> -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible)
> +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible)

Not new to this patch, but we might want to rename this to `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of the other "visible" methods.
Comment 4 youenn fablet 2021-08-05 10:49:04 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 434974 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434974&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value.
> 
> s/by stopping to call/by not calling/
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611
> > -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible)
> > +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible)
> 
> Not new to this patch, but we might want to rename this to
> `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of
> the other "visible" methods.

Thanks for the review, I'll do that renaming in a follow-up: https://bugs.webkit.org/show_bug.cgi?id=228837
Comment 5 youenn fablet 2021-08-05 10:53:07 PDT 
Created attachment 435006 [details]
Patch for landing
Comment 6 EWS 2021-08-06 02:15:58 PDT 
Committed r280720 (240311@main): <https://commits.webkit.org/240311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435006 [details].