Bug 228816 – MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible

[youenn fablet]

<rdar://81077972>

[youenn fablet]

Created attachment 434974 [details]
Patch

[Eric Carlson]

Comment on attachment 434974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434974&action=review

> Source/WebCore/ChangeLog:11
> +        We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value.

s/by stopping to call/by not calling/

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611
> -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible)
> +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible)

Not new to this patch, but we might want to rename this to `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of the other "visible" methods.

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 434974 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434974&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        We do this by stopping to call ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value.
> 
> s/by stopping to call/by not calling/
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:611
> > -void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool visible)
> > +void MediaPlayerPrivateMediaStreamAVFObjC::setVisible(bool isVisible)
> 
> Not new to this patch, but we might want to rename this to
> `setPageIsVisible`, or maybe `setViewportIsVisible`, to match the names of
> the other "visible" methods.

Thanks for the review, I'll do that renaming in a follow-up: https://bugs.webkit.org/show_bug.cgi?id=228837

[youenn fablet]

Created attachment 435006 [details]
Patch for landing

[EWS]

Committed r280720 (240311@main): <https://commits.webkit.org/240311@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435006 [details].