Bug 228808 - Change WebSocket.cpp to @no-unify, since it’s hard to do that for someone without a Mac
Summary: Change WebSocket.cpp to @no-unify, since it’s hard to do that for someone wit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 226557
  Show dependency tree / graph
 
Reported: 2021-08-04 18:15 PDT by Darin Adler
Modified: 2021-08-05 06:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2021-08-04 18:18 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-08-04 18:15:51 PDT 
Michael Catanzaro asked for help making WebSocket.cpp a @no-unify file, including the Xcode project changes.
Comment 1 Darin Adler 2021-08-04 18:18:26 PDT 
Created attachment 434960 [details]
Patch
Comment 2 Darin Adler 2021-08-04 18:20:31 PDT 
Not thrilled to be adding more @no-unify. We’d like to do the reverse and have fewer separately compiled files!
Comment 3 EWS 2021-08-04 19:52:07 PDT 
Committed r280677 (240279@main): <https://commits.webkit.org/240279@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434960 [details].
Comment 4 Radar WebKit Bug Importer 2021-08-04 19:53:18 PDT 
<rdar://problem/81546248>
Comment 5 Michael Catanzaro 2021-08-05 06:43:07 PDT 
Thanks Darin!

(In reply to Darin Adler from comment #2)
> Not thrilled to be adding more @no-unify. We’d like to do the reverse and
> have fewer separately compiled files!

I know. :/ I've tried my best in bug #226557 and concluded it's either do this, or build all of WebCore with -Wno-stringop-overread. I'd rather suppress it for this one file than the entire project.