RESOLVED FIXED 228805
[LFC][IFC] Add support for -webkit-nbsp-mode: space 
https://bugs.webkit.org/show_bug.cgi?id=228805
Summary [LFC][IFC] Add support for -webkit-nbsp-mode: space
zalan
Reported 2021-08-04 15:54:09 PDT
treat nbsp as regular space
Attachments
Patch (12.66 KB, patch)
2021-08-04 16:02 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (6.70 KB, patch)
2021-08-20 04:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-08-04 16:02:04 PDT
Created attachment 434947 [details] Patch
Antti Koivisto
Comment 2 2021-08-05 05:20:11 PDT
Comment on attachment 434947 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434947&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54 > - FlowHasWebKitNBSPMode = 1LLU << 14, maybe just leave a hole, like // Unused = 1LLU << 14, to avoid having to shift everything.
zalan
Comment 3 2021-08-05 06:57:45 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 434947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434947&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54 > > - FlowHasWebKitNBSPMode = 1LLU << 14, > > maybe just leave a hole, like > > // Unused = 1LLU << 14, > > to avoid having to shift everything. Indeed -but I like looking at the shrinking list.
Antti Koivisto
Comment 4 2021-08-05 07:25:33 PDT
> Indeed -but I like looking at the shrinking list. I like lists full of comments.
Radar WebKit Bug Importer
Comment 5 2021-08-11 15:55:21 PDT
<rdar://problem/81817558>
EWS
Comment 6 2021-08-19 20:17:21 PDT
Tools/Scripts/svn-apply failed to apply attachment 434947 [details] to trunk. Please resolve the conflicts and upload a new patch.
zalan
Comment 7 2021-08-20 04:35:39 PDT
Created attachment 435970 [details] Patch
EWS
Comment 8 2021-08-20 05:34:58 PDT
Committed r281306 (240726@main): <https://commits.webkit.org/240726@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435970 [details].
Note You need to log in before you can comment on or make changes to this bug.