Bug 228805 - [LFC][IFC] Add support for -webkit-nbsp-mode: space
Summary: [LFC][IFC] Add support for -webkit-nbsp-mode: space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-04 15:54 PDT by zalan
Modified: 2021-08-20 05:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.66 KB, patch)
2021-08-04 16:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.70 KB, patch)
2021-08-20 04:35 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-08-04 15:54:09 PDT 
treat nbsp as regular space
Comment 1 zalan 2021-08-04 16:02:04 PDT 
Created attachment 434947 [details]
Patch
Comment 2 Antti Koivisto 2021-08-05 05:20:11 PDT 
Comment on attachment 434947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434947&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54
> -    FlowHasWebKitNBSPMode                        = 1LLU  << 14,

maybe just leave a hole, like

// Unused                        = 1LLU << 14,

to avoid having to shift everything.
Comment 3 zalan 2021-08-05 06:57:45 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 434947 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434947&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54
> > -    FlowHasWebKitNBSPMode                        = 1LLU  << 14,
> 
> maybe just leave a hole, like
> 
> // Unused                        = 1LLU << 14,
> 
> to avoid having to shift everything.
Indeed -but I like looking at the shrinking list.
Comment 4 Antti Koivisto 2021-08-05 07:25:33 PDT 
> Indeed -but I like looking at the shrinking list.

I like lists full of comments.
Comment 5 Radar WebKit Bug Importer 2021-08-11 15:55:21 PDT 
<rdar://problem/81817558>
Comment 6 EWS 2021-08-19 20:17:21 PDT 
Tools/Scripts/svn-apply failed to apply attachment 434947 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 zalan 2021-08-20 04:35:39 PDT 
Created attachment 435970 [details]
Patch
Comment 8 EWS 2021-08-20 05:34:58 PDT 
Committed r281306 (240726@main): <https://commits.webkit.org/240726@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435970 [details].