Bug 228794 - [LFC][Integration] line-clamp is an unsupported CSS property
Summary: [LFC][Integration] line-clamp is an unsupported CSS property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-04 13:15 PDT by zalan
Modified: 2021-08-20 05:49 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2021-08-04 13:37 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.49 KB, patch)
2021-08-05 16:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-08-04 13:15:12 PDT 
we should bail out on line-clamp instead of deprecated flex box (laying out the flex item is ok as long as we don't have to do line clamping -which requires legacy line structures)
Comment 1 zalan 2021-08-04 13:37:01 PDT 
Created attachment 434930 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-08-04 13:43:01 PDT 
Comment on attachment 434930 [details]
Patch

No test coverage?
Comment 3 zalan 2021-08-04 13:44:42 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 434930 [details]
> Patch
> 
> No test coverage?
We do have some line-clamp tests and the test coverage here is whether we still pass them (i.e. we run legacy line layout) or not.
Comment 4 zalan 2021-08-05 16:09:20 PDT 
Created attachment 435037 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-08-11 13:16:18 PDT 
<rdar://problem/81809991>
Comment 6 EWS 2021-08-20 05:49:55 PDT 
Committed r281308 (240728@main): <https://commits.webkit.org/240728@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435037 [details].