Bug 22879 - Qt WebKit does not build on Windows with MSVC
Summary: Qt WebKit does not build on Windows with MSVC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 06:51 PST by Yael
Modified: 2008-12-17 09:09 PST (History)
1 user (show)

See Also:

Attachments
Fix Windows buid with MSVC 2005 (1.59 KB, patch)
2008-12-16 06:53 PST, Yael 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2008-12-16 06:51:49 PST 
Qt WebKit does not build on Windows with MSVC 2005.
Comment 1 Yael 2008-12-16 06:53:01 PST 
Created attachment 26051 [details]
Fix Windows buid with MSVC 2005
Comment 2 Adam Roben (:aroben) 2008-12-16 10:59:01 PST 
Comment on attachment 26051 [details]
Fix Windows buid with MSVC 2005

> +++ WebCore/platform/win/SystemTimeWin.cpp	(working copy)
> @@ -32,7 +32,11 @@
>  #if COMPILER(MINGW)
>  #include <float.h>
>  #define FLOAT_MAX FLT_MAX
> +#else
> +#if PLATFORM(QT)
> +#include <float.h>
>  #endif
> +#endif

I think using #elif would be better than introducing an extra level of nesting here.

r=me
Comment 3 Tor Arne Vestbø 2008-12-17 09:09:07 PST 
Thanks Yael! Landed in r39335