RESOLVED FIXED 22879
Qt WebKit does not build on Windows with MSVC 
https://bugs.webkit.org/show_bug.cgi?id=22879
Summary Qt WebKit does not build on Windows with MSVC
Yael
Reported 2008-12-16 06:51:49 PST
Qt WebKit does not build on Windows with MSVC 2005.
Attachments
Fix Windows buid with MSVC 2005 (1.59 KB, patch)
2008-12-16 06:53 PST, Yael 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2008-12-16 06:53:01 PST
Created attachment 26051 [details] Fix Windows buid with MSVC 2005
Adam Roben (:aroben)
Comment 2 2008-12-16 10:59:01 PST
Comment on attachment 26051 [details] Fix Windows buid with MSVC 2005 > +++ WebCore/platform/win/SystemTimeWin.cpp (working copy) > @@ -32,7 +32,11 @@ > #if COMPILER(MINGW) > #include <float.h> > #define FLOAT_MAX FLT_MAX > +#else > +#if PLATFORM(QT) > +#include <float.h> > #endif > +#endif I think using #elif would be better than introducing an extra level of nesting here. r=me
Tor Arne Vestbø
Comment 3 2008-12-17 09:09:07 PST
Thanks Yael! Landed in r39335
Note You need to log in before you can comment on or make changes to this bug.