Bug 228784 - [iOS] Gather logs for IOKit class
Summary: [iOS] Gather logs for IOKit class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-04 10:55 PDT by Per Arne Vollan
Modified: 2021-09-02 15:44 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.30 KB, patch)
2021-08-04 10:56 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2021-08-04 11:33 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.29 KB, patch)
2021-09-02 14:18 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-08-04 10:55:17 PDT
Add telemetry for an IOKit class on iOS.
Comment 1 Per Arne Vollan 2021-08-04 10:56:23 PDT
Created attachment 434913 [details]
Patch
Comment 2 Per Arne Vollan 2021-08-04 11:33:46 PDT
Created attachment 434918 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-08-04 11:34:12 PDT
<rdar://problem/81525024>
Comment 4 Per Arne Vollan 2021-09-02 14:18:09 PDT
Created attachment 437197 [details]
Patch
Comment 5 Brent Fulgham 2021-09-02 15:22:34 PDT
Comment on attachment 437197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437197&action=review

r=me

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:101
>                      iokit-external-method)

Did we want to exclude any known method numbers for this to reduce logging?
Comment 6 Per Arne Vollan 2021-09-02 15:32:48 PDT
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 437197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437197&action=review
> 
> r=me
> 
> > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:101
> >                      iokit-external-method)
> 
> Did we want to exclude any known method numbers for this to reduce logging?

That's a good point, although, at this point, I don't think we have any known method numbers.

Thanks for reviewing!
Comment 7 EWS 2021-09-02 15:44:13 PDT
Committed r281960 (241267@main): <https://commits.webkit.org/241267@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437197 [details].