Bug 22878 – It should be possible to post (clone) built-in JS objects to Workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Alexey Proskuryakov]

Worker.postMessage only takes strings now, but the spec has been recently changed to allow arbitrary JS objects, such as Arrays and Objects. We need to support this.

This is similar to JSON, but not quite the same.

[Alexey Proskuryakov]

<rdar://problem/6448422>

[Oliver Hunt]

Created attachment 40694 [details]
It should be possible to post (clone) built-in JS objects to Workers

[Oliver Hunt]

Created attachment 40699 [details]
It should be possible to post (clone) built-in JS objects to Workers

[Gavin Barraclough]

Comment on attachment 40699 [details]
It should be possible to post (clone) built-in JS objects to Workers

In the test case, I'd suggest renaming 'equal' to something more descriptive (I initially wondered, "why not just use ==" :-) ).  Maybe 'isCloneOf'?

In SerializedArray, all index values should be less than 'm_length'.

In SerializedScriptValueData, I think 'operator bool ()' should be 'operator bool()' – a quick grep of JSC would seem to agree with this.

r+

[Oliver Hunt]

Landed r49214

[Shinichiro Hamaji]

(In reply to comment #5)
> Landed r49214

This expected.txt contains this line:

> CONSOLE MESSAGE: line 54: RangeError: Maximum call stack size exceeded.

Is this OK?

Also... it is very nice if you modify the test so that the results don't contain "PST" . Maybe we can use the value of getTime like

    if (equal(actualValue, expectedValue)) {
        if (expectedValue && expectedValue.getTime) {
            expectedValue = expectedValue.getTime() + " (the value of getTime)
        }
        console.innerHTML += "PASS: " + actual + " is " + expectedValue + " of type " + typeof actualValue + "<br>";
    } else

?