Bug 228777 - Remove unneeded sandbox extension code
Summary: Remove unneeded sandbox extension code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-04 08:54 PDT by Per Arne Vollan
Modified: 2022-05-05 09:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.48 KB, patch)
2021-08-04 08:56 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (13.99 KB, patch)
2022-02-07 10:02 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-08-04 08:54:24 PDT 
Since the GPU process is now enabled by default, some related sandbox extension code can be removed.
Comment 1 Radar WebKit Bug Importer 2021-08-04 08:55:16 PDT 
<rdar://problem/81516828>
Comment 2 Per Arne Vollan 2021-08-04 08:56:49 PDT 
Created attachment 434906 [details]
Patch
Comment 3 Brent Fulgham 2021-08-30 16:44:21 PDT 
Comment on attachment 434906 [details]
Patch

Should we hold off on this until the GPU Process team is confident they don't need to debug or A/B test anymore?
Comment 4 Per Arne Vollan 2021-08-31 07:32:33 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 434906 [details]
> Patch
> 
> Should we hold off on this until the GPU Process team is confident they
> don't need to debug or A/B test anymore?

That is a good point. I think we may hold off a little while longer.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2022-02-07 10:02:23 PST 
Created attachment 451119 [details]
Patch
Comment 6 Jean-Yves Avenard [:jya] 2022-02-07 12:37:33 PST 
Comment on attachment 451119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451119&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-8204
> -        "com.apple.audio.AudioComponentPrefs"_s, "com.apple.audio.AudioComponentRegistrar"_s,

Will this break webaudio that is happening in the content process?
Comment 7 Per Arne Vollan 2022-02-07 12:59:34 PST 
(In reply to Jean-Yves Avenard [:jya] from comment #6)
> Comment on attachment 451119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451119&action=review
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:-8204
> > -        "com.apple.audio.AudioComponentPrefs"_s, "com.apple.audio.AudioComponentRegistrar"_s,
> 
> Will this break webaudio that is happening in the content process?

I don't believe it will, since we only create these sandbox extensions if Media in GPUP is not enabled.

Thanks for reviewing!
Comment 8 Brent Fulgham 2022-02-18 14:35:58 PST 
Comment on attachment 451119 [details]
Patch

r=me
Comment 9 Per Arne Vollan 2022-02-18 14:45:48 PST 
(In reply to Brent Fulgham from comment #8)
> Comment on attachment 451119 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 10 Per Arne Vollan 2022-02-18 16:27:09 PST 
Committed r290183 (?): <https://commits.webkit.org/r290183>
Comment 11 Jean-Yves Avenard [:jya] 2022-05-05 09:15:14 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/525