Bug 228773 – [macOS] Update message filters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Update message filters with enforcement on macOS based on telemetry.

[Radar WebKit Bug Importer]

<rdar://problem/81514311>

[Per Arne Vollan]

Created attachment 434903 [details]
Patch

[Brent Fulgham]

Comment on attachment 434903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434903&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273
> +        (allow (with telemetry-backtrace) iokit-external-method

Do we really want telemetry-backtrace on these two methods?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 434903 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434903&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273
> > +        (allow (with telemetry-backtrace) iokit-external-method
> 
> Do we really want telemetry-backtrace on these two methods?

Yes, I believe so. They are not expected to be frequently used.

Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 434903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434903&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:269
> +        (deny (with telemetry) (with message "IOMobileFramebufferUserClient")

So we deny (with telemetry) pretty much all uses of iokit-async-external-method, and iokit-external-trap ...

>>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273
>>> +        (allow (with telemetry-backtrace) iokit-external-method
>> 
>> Do we really want telemetry-backtrace on these two methods?
> 
> Yes, I believe so. They are not expected to be frequently used.
> 
> Thanks for reviewing!

... and allow with backtrace iokit-external-method for these two methods.

That means everything else is denied without telemetry, right?

If so, I think this seems right.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #5)
> Comment on attachment 434903 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434903&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:269
> > +        (deny (with telemetry) (with message "IOMobileFramebufferUserClient")
> 
> So we deny (with telemetry) pretty much all uses of
> iokit-async-external-method, and iokit-external-trap ...
> 
> >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273
> >>> +        (allow (with telemetry-backtrace) iokit-external-method
> >> 
> >> Do we really want telemetry-backtrace on these two methods?
> > 
> > Yes, I believe so. They are not expected to be frequently used.
> > 
> > Thanks for reviewing!
> 
> ... and allow with backtrace iokit-external-method for these two methods.
> 
> That means everything else is denied without telemetry, right?
> 
> If so, I think this seems right.

Actually, I think we are keeping telemetry without backtraces for the denied items, in order to be able to see if they are being used.

Thanks for reviewing!

[EWS]

Committed r280644 (240255@main): <https://commits.webkit.org/240255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434903 [details].