Bug 228766 - [Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Summary: [Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 228764
  Show dependency tree / graph
 
Reported: 2021-08-03 22:30 PDT by Myles C. Maxfield
Modified: 2021-08-04 12:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.18 KB, patch)
2021-08-03 22:31 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (11.31 KB, patch)
2021-08-04 00:48 PDT, Myles C. Maxfield 		simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-08-03 22:30:05 PDT 
[Cocoa] Tweak the formatting for passing NSArrays to TextStreams
Comment 1 Myles C. Maxfield 2021-08-03 22:31:06 PDT 
Created attachment 434886 [details]
Patch
Comment 2 Myles C. Maxfield 2021-08-04 00:48:39 PDT 
Created attachment 434891 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-08-04 08:56:44 PDT 
Comment on attachment 434891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434891&action=review

> Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:71
> +    // Intentionally don't cast to id<NSObject> because we want to make sure that this can be called from raw C++ code.

But this is a .mm file so is being complied as ObjC++. Wouldn't a proper test be in a .cpp file?
Comment 4 Myles C. Maxfield 2021-08-04 12:37:47 PDT 
Committed r280651 (240262@main): <https://commits.webkit.org/240262@main>
Comment 5 Radar WebKit Bug Importer 2021-08-04 12:38:18 PDT 
<rdar://problem/81528316>