RESOLVED FIXED228758
[webkitpy] Handle case where no existing simulators are defined 
https://bugs.webkit.org/show_bug.cgi?id=228758
Summary [webkitpy] Handle case where no existing simulators are defined
Jonathan Bedard
Reported 2021-08-03 15:34:45 PDT
We need to handle the case where a machine has no existing simulated devices.
Attachments
Patch (2.27 KB, patch)
2021-08-03 15:38 PDT, Jonathan Bedard 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-08-03 15:35:41 PDT
<rdar://problem/81484040>
Jonathan Bedard
Comment 2 2021-08-03 15:38:51 PDT
Created attachment 434866 [details] Patch
Jonathan Bedard
Comment 3 2021-08-03 16:25:23 PDT
The important piece to understand with this change is that comparing device types is fuzzy. Ie, `iPhone running iOS` matches `iPhone 10 running iOS 14`, but not `iPad running iOS`. Many scripts, and run-api-tests, in particular, don't exactly define exact device types and instead rely on the devices available on a machine. This is where the current issue is. If no devices are available, we don't have anything to match against and end up with a device type too generic for actually running tests. The solution to this (as implemented in this patch) is to check all device types this machine declares, even if those types are not currently associated with a simulated device, from newest to oldest, picking the first one that matches the requested device type.
EWS
Comment 4 2021-08-03 16:40:17 PDT
Committed r280622 (240235@main): <https://commits.webkit.org/240235@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434866 [details].
Note You need to log in before you can comment on or make changes to this bug.