Bug 228737 – Crash while reading WebGL drawing buffer if canvas image buffer allocation fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kimmo Kinnunen]

Crash while reading WebGL drawing buffer if canvas image buffer allocation fails

[Kimmo Kinnunen]

<rdar://81150042>

[Kimmo Kinnunen]

Created attachment 434827 [details]
Patch

[Brent Fulgham]

Comment on attachment 434827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434827&action=review

Looks good! r=me

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1221
> +            if (auto buffer = base.buffer()) {

Is a nullptr buffer something we should report in a log message or something? Or perhaps that allocation failure is logged elsewhere?

[Kimmo Kinnunen]

(In reply to Brent Fulgham from comment #3)
> > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1221
> > +            if (auto buffer = base.buffer()) {
> 
> Is a nullptr buffer something we should report in a log message or
> something? Or perhaps that allocation failure is logged elsewhere?

Reported already in void HTMLCanvasElement::createImageBuffer() const

[EWS]

Committed r280601 (240219@main): <https://commits.webkit.org/240219@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434827 [details].