Bug 228722 - [Live Text] [iOS] Provide a presenting `UIViewController` for machine readable code actions so that they are related to the same view
Summary: [Live Text] [iOS] Provide a presenting `UIViewController` for machine readabl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-02 16:19 PDT by Devin Rousso
Modified: 2021-08-03 11:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2021-08-02 16:20 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (4.95 KB, patch)
2021-08-02 19:12 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-08-02 16:19:42 PDT 
.
Comment 1 Devin Rousso 2021-08-02 16:20:43 PDT 
Created attachment 434798 [details]
Patch
Comment 2 Devin Rousso 2021-08-02 16:21:31 PDT 
<rdar://problem/81178584>
Comment 3 Tim Horton 2021-08-02 17:05:38 PDT 
Comment on attachment 434798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434798&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:10161
> +static UIViewController *viewControllerForView(UIView *view)

Pretty sure we have a canonical implementation of this that also lets the client give you a more appropriate VC, might want to find that and use it instead.
Comment 4 Tim Horton 2021-08-02 17:09:35 PDT 
Specifically referring to _viewControllerForFullScreenPresentationFromView
Comment 5 Devin Rousso 2021-08-02 19:12:44 PDT 
Created attachment 434808 [details]
Patch
Comment 6 EWS 2021-08-03 11:22:54 PDT 
Committed r280603 (240221@main): <https://commits.webkit.org/240221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434808 [details].