228714 – REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts

Bug 228714 - REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts

Summary: REGRESSION (r280531): multiple modern-media-controls tests have become flaky ...

Status:	REOPENED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Jer Noble

URL:
Keywords:	InRadar

Duplicates (1):	228742 (view as bug list)
Depends on:
Blocks:

Reported:	2021-08-02 13:33 PDT by Eric Hutchison
Modified:	2021-08-03 18:11 PDT (History)
CC List:	10 users (show)

See Also:	228560

Attachments
Patch (2.59 KB, patch) 2021-08-02 15:09 PDT, Jer Noble	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Hutchison 2021-08-02 13:33:10 PDT

media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-off.html 

is a flaky timeout on BigSur.

History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fcontrols-visibility-support%2Fcontrols-visibility-support-controls-off.html; https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/r434764-9136/results.html

Results: https://build.webkit.org/results/Apple-BigSur-Debug-AppleSilicon-WK1-Tests/r280531%20(2870)/results.html

Diff: 404 error

Timeout issues started with https://trac.webkit.org/changeset/280531/webkit.

Comment 1 Radar WebKit Bug Importer 2021-08-02 13:33:53 PDT

<rdar://problem/81426715>

Comment 2 Radar WebKit Bug Importer 2021-08-02 13:34:16 PDT

<rdar://problem/81426733>

Comment 3 Ryan Haddad 2021-08-02 13:37:45 PDT

I think this affects many modern-media-controls tests.

We saw this before when the change was originally landed (https://bugs.webkit.org/show_bug.cgi?id=228660), which led to it being reverted.

Comment 4 Eric Hutchison 2021-08-02 13:50:52 PDT

Appears to have been caused by rdar://81336280 ([Cocoa] Remove support for AVAssetImageGenerator (228560)).

Comment 5 Jer Noble 2021-08-02 15:09:03 PDT

Created attachment 434791 [details]
Patch

Comment 6 EWS 2021-08-03 06:15:46 PDT

Committed r280589 (240211@main): <https://commits.webkit.org/240211@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434791 [details].

Comment 7 ayumi_kojima 2021-08-03 11:58:53 PDT

*** Bug 228742 has been marked as a duplicate of this bug. ***

Comment 8 Ryan Haddad 2021-08-03 18:11:09 PDT

Reverted r280531 and r280589 for reason:

caused

Committed r280624 (240237@main): <https://commits.webkit.org/240237@main>