Bug 228701 - [PlayStation] Make C files in testapi compile with a C standard rather than C++ one
Summary: [PlayStation] Make C files in testapi compile with a C standard rather than C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-02 09:05 PDT by Stephan Szabo
Modified: 2021-08-02 16:40 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2021-08-02 09:28 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-08-02 09:05:43 PDT 
Building of testapi for playstation using Visual Studio started to fail for me complaining about having the argument to use c++17 as the standard for the .C files. We've seen this before and generally add either a compile as C++ or use an appropriate standard in our PlatformPlayStation.cmake.
Comment 1 Stephan Szabo 2021-08-02 09:28:06 PDT 
Created attachment 434759 [details]
Patch
Comment 2 Ross Kirsling 2021-08-02 12:04:28 PDT 
Comment on attachment 434759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434759&action=review

r=me

> Source/JavaScriptCore/shell/PlatformPlayStation.cmake:34
> +        PROPERTIES COMPILE_FLAGS --std=gnu17

I take it the GNU extensions are needed?
Comment 3 Stephan Szabo 2021-08-02 12:20:03 PDT 
Yes - something included tries to do some inline assembly which is unhappy in plain C mode.
Comment 4 EWS 2021-08-02 16:39:17 PDT 
Committed r280569 (240193@main): <https://commits.webkit.org/240193@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434759 [details].
Comment 5 Radar WebKit Bug Importer 2021-08-02 16:40:17 PDT 
<rdar://problem/81435038>