Bug 228691 - Skip unnecessary invalidation of document level NodeList caches
Summary: Skip unnecessary invalidation of document level NodeList caches
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-01 14:55 PDT by Maciej Stachowiak
Modified: 2021-08-22 21:20 PDT (History)
6 users (show)

See Also:

Attachments
For EWS testing only (2.44 KB, patch)
2021-08-01 14:56 PDT, Maciej Stachowiak 		mjs: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2021-08-01 14:55:19 PDT 
Skip unnecessary invalidation of document level NodeList caches
Comment 1 Maciej Stachowiak 2021-08-01 14:56:46 PDT 
Created attachment 434727 [details]
For EWS testing only
Comment 2 Maciej Stachowiak 2021-08-01 14:58:53 PDT 
Comment on attachment 434727 [details]
For EWS testing only

Not for landing. This version of the patch is like incorrect, as some NodeLists or Collections may need document-level invalidation even when the node isn't in the document. This is probably true for HTMLFormControlCollection, not clear what else may be affected. Testing if this builds and passes tests for now.
Comment 3 Radar WebKit Bug Importer 2021-08-08 14:56:17 PDT 
<rdar://problem/81675082>
Comment 4 Darin Adler 2021-08-22 21:20:51 PDT 
Comment on attachment 434727 [details]
For EWS testing only

View in context: https://bugs.webkit.org/attachment.cgi?id=434727&action=review

> Source/WebCore/ChangeLog:10
> +        Ported from an abansoned Chromium change by Adithya Srinivasan.

Typo: abansoned