Bug 22868 - xslt-enc16.xml and xslt-enc16to16.xml have wrong line endings on windows
Summary: xslt-enc16.xml and xslt-enc16to16.xml have wrong line endings on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-15 13:54 PST by Tony Chang
Modified: 2009-01-11 01:51 PST (History)
0 users

See Also:

Attachments
svn pd svn:eol-style (1.73 KB, patch)
2008-12-15 14:11 PST, Tony Chang 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-12-15 13:54:24 PST 
The layout tests fast/xslt/xslt-enc16.xml and fast/xslt/xslt-enc16to16.xml have the wrong line endings when checked out on windows.  It looks like there was an attempted fix in r32776:
  http://trac.webkit.org/changeset/32776

But this change didn't remove the svn:eol-style which is still set to native.  I think if we just delete the svn:eol-style, the tests will be checked out properly.

More information about the svn:mime-type here:
  http://svnbook.red-bean.com/en/1.1/apas08.html
Comment 1 Tony Chang 2008-12-15 14:11:23 PST 
Created attachment 26032 [details]
svn pd svn:eol-style
Comment 2 Darin Adler 2008-12-15 14:28:15 PST 
Comment on attachment 26032 [details]
svn pd svn:eol-style

r=me
Comment 3 Alexey Proskuryakov 2009-01-11 01:51:59 PST 
Committed revision 39790.

This patch was made from non-root directory, so naively applying it modified WebKit/ChangeLog, not WebKit/LayoutTests/ChangeLog. To make landing easier, please make patches from root directory (you can pass a list of files/directories to scan to make the process faster, e.g. "svn-create-patch LayoutTests/ChangeLog LayoutTests/fast/xsl").