Bug 228676 - [JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search
Summary: [JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-31 00:05 PDT by Yusuke Suzuki
Modified: 2021-08-02 10:47 PDT (History)
10 users (show)

See Also:


Attachments
Patch (17.69 KB, patch)
2021-07-31 00:10 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (17.29 KB, patch)
2021-07-31 00:14 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (17.35 KB, patch)
2021-07-31 00:20 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (17.49 KB, patch)
2021-07-31 13:51 PDT, Yusuke Suzuki
sbarati: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-07-31 00:05:47 PDT
[JSC] Yarr should use Bitmap instead of ByteVector for BoyerMoore search
Comment 1 Yusuke Suzuki 2021-07-31 00:10:39 PDT
Created attachment 434690 [details]
Patch
Comment 2 Yusuke Suzuki 2021-07-31 00:14:13 PDT
Created attachment 434691 [details]
Patch
Comment 3 Yusuke Suzuki 2021-07-31 00:20:17 PDT
Created attachment 434692 [details]
Patch
Comment 4 Yusuke Suzuki 2021-07-31 13:51:45 PDT
Created attachment 434703 [details]
Patch
Comment 5 Saam Barati 2021-08-02 10:14:24 PDT
Comment on attachment 434703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434703&action=review

> Source/JavaScriptCore/yarr/YarrJIT.cpp:2428
> +                            auto matched = branchTestBit64(NonZero, regT2, regT0); // We can ignore upper bits since module-64 is performed.

module->modulo

The instruction itself performs modulo 64?
Comment 6 Saam Barati 2021-08-02 10:14:34 PDT
r=me
Comment 7 Yusuke Suzuki 2021-08-02 10:39:57 PDT
Comment on attachment 434703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434703&action=review

Thanks!

>> Source/JavaScriptCore/yarr/YarrJIT.cpp:2428
>> +                            auto matched = branchTestBit64(NonZero, regT2, regT0); // We can ignore upper bits since module-64 is performed.
> 
> module->modulo
> 
> The instruction itself performs modulo 64?

Yes. https://www.felixcloutier.com/x86/bt
Comment 8 Yusuke Suzuki 2021-08-02 10:46:42 PDT
Committed r280544 (240171@main): <https://commits.webkit.org/240171@main>
Comment 9 Radar WebKit Bug Importer 2021-08-02 10:47:18 PDT
<rdar://problem/81419055>