Bug 228671 - REGRESSION (r271348): Web Inspector: Table headers have vertical scrollbar
Summary: REGRESSION (r271348): Web Inspector: Table headers have vertical scrollbar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-30 16:54 PDT by Nikita Vasilyev
Modified: 2021-08-12 12:07 PDT (History)
4 users (show)

See Also:

Attachments
[Image] Bug (54.39 KB, image/png)
2021-07-30 16:54 PDT, Nikita Vasilyev 		no flags Details
Patch (1.28 KB, patch)
2021-08-12 01:24 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (95.80 KB, image/png)
2021-08-12 01:25 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2021-07-30 16:54:29 PDT 
Created attachment 434674 [details]
[Image] Bug

This is likely a recent regression.
Comment 1 Radar WebKit Bug Importer 2021-08-06 16:55:16 PDT 
<rdar://problem/81638278>
Comment 2 Nikita Vasilyev 2021-08-12 01:11:06 PDT 
I bisected and it showed r271348. Which is interesting - it's a change in WebCore, not Web Inspector.


> "The baseline of an 'inline-block' is the baseline of its last line box in the normal flow, unless it has either no in-flow line boxes
> or if its 'overflow' property has a computed value other than 'visible', in which case the baseline is the bottom margin edge."
> ​https://www.w3.org/TR/CSS22/visudet.html#leading
Comment 3 Nikita Vasilyev 2021-08-12 01:24:18 PDT 
Created attachment 435400 [details]
Patch

Irregardless of the WebCore change that caused the regression, a less error-prone way to fix this is simply to set "overflow: hidden".
Comment 4 Nikita Vasilyev 2021-08-12 01:25:45 PDT 
Created attachment 435401 [details]
[Image] With patch applied

No scrollbar with the patch applied.
Comment 5 Devin Rousso 2021-08-12 12:03:42 PDT 
Comment on attachment 435400 [details]
Patch

rs=me
Comment 6 EWS 2021-08-12 12:07:33 PDT 
Committed r280974 (240478@main): <https://commits.webkit.org/240478@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435400 [details].