Bug 228641 – Attribute nw connections to the source application

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

<rdar://81039713>

[youenn fablet]

Created attachment 434623 [details]
Patch

[youenn fablet]

Created attachment 434625 [details]
Patch

[Alex Christensen]

Comment on attachment 434625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434625&action=review

We also set configuration.get()._attributedBundleIdentifier for SafariViewController based on the page ID.

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:100
> +        nw_parameters_set_source_application(tcpTLS.get(), *reinterpret_cast<const audit_token_t*>(CFDataGetBytePtr(sourceApplicationAuditData)));

RELEASE_ASSERT(CFDataGetSize(sourceApplicationAuditData) == sizeof(audit_token_t));

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:239
> +        nw_parameters_set_source_application(parameters, *reinterpret_cast<const audit_token_t*>(CFDataGetBytePtr(m_sourceApplicationAuditData.get())));

ditto

[youenn fablet]

Created attachment 434626 [details]
Patch

[youenn fablet]

Thanks for the review.

(In reply to Alex Christensen from comment #3)
> Comment on attachment 434625 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434625&action=review
> 
> We also set configuration.get()._attributedBundleIdentifier for
> SafariViewController based on the page ID.

Will do in a follow-up as we do not have the page ID.

> > Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:100
> > +        nw_parameters_set_source_application(tcpTLS.get(), *reinterpret_cast<const audit_token_t*>(CFDataGetBytePtr(sourceApplicationAuditData)));
> 
> RELEASE_ASSERT(CFDataGetSize(sourceApplicationAuditData) ==
> sizeof(audit_token_t));
> 
> > Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:239
> > +        nw_parameters_set_source_application(parameters, *reinterpret_cast<const audit_token_t*>(CFDataGetBytePtr(m_sourceApplicationAuditData.get())));
> 
> ditto

I changed it to directly get an audit_token_t from network process.

[youenn fablet]

Created attachment 434629 [details]
Patch for landing

[EWS]

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

[youenn fablet]

Created attachment 434638 [details]
Patch for landing

[youenn fablet]

> Will do in a follow-up as we do not have the page ID.

https://bugs.webkit.org/show_bug.cgi?id=228649

[EWS]

Committed r280481 (240116@main): <https://commits.webkit.org/240116@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434638 [details].