Bug 228621 - [git-webkit] Forward errors from log and blame
Summary: [git-webkit] Forward errors from log and blame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-29 16:40 PDT by Jonathan Bedard
Modified: 2021-07-30 10:46 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2021-07-30 08:23 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (2.50 KB, patch)
2021-07-30 10:15 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-07-29 16:40:03 PDT
We should forward errors from `git/svn log/blame` commands.
Comment 1 Radar WebKit Bug Importer 2021-07-29 16:40:17 PDT
<rdar://problem/81297642>
Comment 2 Jonathan Bedard 2021-07-30 08:23:25 PDT
Created attachment 434628 [details]
Patch
Comment 3 Aakash Jain 2021-07-30 08:58:21 PDT
Comment on attachment 434628 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434628&action=review

rs=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258
> +            if not log_output.returncode:

Might be more clear to explicitly compare with 0

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260
> +                    sys.stderr.write(line)

why not print? Also, can you avoid this for loop and directly print whole thing in a single statement?
Comment 4 Jonathan Bedard 2021-07-30 10:02:00 PDT
(In reply to Aakash Jain from comment #3)
> Comment on attachment 434628 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434628&action=review
> 
> rs=me
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258
> > +            if not log_output.returncode:
> 
> Might be more clear to explicitly compare with 0

It might be 'None', particularly for `git log` or `svn log`

> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260
> > +                    sys.stderr.write(line)
> 
> why not print? Also, can you avoid this for loop and directly print whole
> thing in a single statement?
Comment 5 Jonathan Bedard 2021-07-30 10:15:06 PDT
Created attachment 434643 [details]
Patch for landing
Comment 6 EWS 2021-07-30 10:46:45 PDT
Committed r280483 (240118@main): <https://commits.webkit.org/240118@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434643 [details].