RESOLVED FIXED 228621
[git-webkit] Forward errors from log and blame 
https://bugs.webkit.org/show_bug.cgi?id=228621
Summary [git-webkit] Forward errors from log and blame
Jonathan Bedard
Reported 2021-07-29 16:40:03 PDT
We should forward errors from `git/svn log/blame` commands.
Attachments
Patch (2.79 KB, patch)
2021-07-30 08:23 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.50 KB, patch)
2021-07-30 10:15 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-29 16:40:17 PDT
<rdar://problem/81297642>
Jonathan Bedard
Comment 2 2021-07-30 08:23:25 PDT
Created attachment 434628 [details] Patch
Aakash Jain
Comment 3 2021-07-30 08:58:21 PDT
Comment on attachment 434628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434628&action=review rs=me > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258 > + if not log_output.returncode: Might be more clear to explicitly compare with 0 > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260 > + sys.stderr.write(line) why not print? Also, can you avoid this for loop and directly print whole thing in a single statement?
Jonathan Bedard
Comment 4 2021-07-30 10:02:00 PDT
(In reply to Aakash Jain from comment #3) > Comment on attachment 434628 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434628&action=review > > rs=me > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258 > > + if not log_output.returncode: > > Might be more clear to explicitly compare with 0 It might be 'None', particularly for `git log` or `svn log` > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260 > > + sys.stderr.write(line) > > why not print? Also, can you avoid this for loop and directly print whole > thing in a single statement?
Jonathan Bedard
Comment 5 2021-07-30 10:15:06 PDT
Created attachment 434643 [details] Patch for landing
EWS
Comment 6 2021-07-30 10:46:45 PDT
Committed r280483 (240118@main): <https://commits.webkit.org/240118@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434643 [details].
Note You need to log in before you can comment on or make changes to this bug.