Bug 228601 - GCC 11 builds should use -Wno-array-bounds, -Wno-nonnull
Summary: GCC 11 builds should use -Wno-array-bounds, -Wno-nonnull
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 226557
  Show dependency treegraph
 
Reported: 2021-07-29 13:09 PDT by Michael Catanzaro
Modified: 2021-08-05 08:27 PDT (History)
21 users (show)

See Also:


Attachments
Patch (12.20 KB, patch)
2021-07-29 13:14 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-07-29 13:09:09 PDT
Prior to GCC 11, these were good warnings that could catch serious errors. But GCC 11 has just become too sensitive and it's flagging what appear to be harmless cases, and not providing enough feedback to know why. This has resulted in me littering our code with pragmas to suppress GCC's false positives, and I think it's reached the point where it's nicer to just turn off the warnings until such time that GCC gets this under control, and rely on Clang instead in the meantime.

The GCC developers have indicated that these warnings will *always* produce false positives in some circumstances, but with GCC 11 it's just too become too much IMO.
Comment 1 Michael Catanzaro 2021-07-29 13:14:39 PDT
Created attachment 434563 [details]
Patch
Comment 2 EWS 2021-08-05 08:27:11 PDT
Committed r280689 (240291@main): <https://commits.webkit.org/240291@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434563 [details].