Bug 228590 – [webkitcorepy] Catch AttributeError when getting password

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Some Linux distros will raise an AttributeError in keyring when retrieving a password. Given that our code handles cases where keyring fails, we should also catch AttributeErrors.

[Radar WebKit Bug Importer]

<rdar://problem/81278799>

[Jonathan Bedard]

Created attachment 434533 [details]
Patch

[Aakash Jain]

Example of failure: https://ews-build.webkit-uat.org/#/builders/35/builds/105023/steps/10/logs/stdio

Traceback (most recent call last):
  File "Tools/Scripts/check-github-mirror-integrity", line 56, in <module>
    sys.exit(main())
  File "Tools/Scripts/check-github-mirror-integrity", line 37, in main
    mirror_tip = mirror.commit(branch='main')
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 244, in commit
    commit_data = self.request('commits/{}'.format(branch or tag))
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 82, in request
    username, access_token = self.credentials(required=bool(authenticated))
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 71, in credentials
    key_name='token',
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py", line 73, in credentials
    key = keyring.get_password(url, username)
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/core.py", line 42, in get_password
    return _keyring_backend.get_password(service_name, username)
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/backends/file.py", line 62, in get_password
    username = escape_for_ini(username)
  File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/util/escape.py", line 44, in escape
    return "".join(_escape_char(c) for c in value.encode('utf-8'))
AttributeError: 'NoneType' object has no attribute 'encode'

[EWS]

Committed r280435 (240073@main): <https://commits.webkit.org/240073@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434533 [details].