Bug 228586 - Fix fast/speechrecognition/detached-iframe.html
Summary: Fix fast/speechrecognition/detached-iframe.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-29 09:11 PDT by Sihui Liu
Modified: 2021-07-29 12:00 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2021-07-29 09:13 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (2.06 KB, patch)
2021-07-29 11:28 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-07-29 09:11:39 PDT
...
Comment 1 Sihui Liu 2021-07-29 09:13:45 PDT
Created attachment 434526 [details]
Patch
Comment 2 Chris Dumez 2021-07-29 10:06:45 PDT
Comment on attachment 434526 [details]
Patch

r=me although I think that frame.remove() would be more concise.
Comment 3 Sihui Liu 2021-07-29 11:28:56 PDT
Created attachment 434545 [details]
Patch for landing
Comment 4 EWS 2021-07-29 11:58:12 PDT
Committed r280438 (240076@main): <https://commits.webkit.org/240076@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434545 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-29 12:00:45 PDT
<rdar://problem/81283597>