RESOLVED FIXED 228584
[macOS] Remove unneeded sandbox extension member 
https://bugs.webkit.org/show_bug.cgi?id=228584
Summary [macOS] Remove unneeded sandbox extension member
Per Arne Vollan
Reported 2021-07-29 08:27:12 PDT
The commit https://trac.webkit.org/changeset/272999/webkit disabled this, but after adopting API to switch from static font registry to user font registry, this can be re-enabled.
Attachments
Patch (4.31 KB, patch)
2021-07-29 08:30 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.69 KB, patch)
2021-07-29 11:02 PDT, Per Arne Vollan 		darin: review+
DetailsFormatted DiffDiff
Patch (1.99 KB, patch)
2021-08-02 09:59 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-07-29 08:30:14 PDT
Created attachment 434521 [details] Patch
Sam Weinig
Comment 2 2021-07-29 09:52:03 PDT
Comment on attachment 434521 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434521&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1282 > +void WebProcess::switchFromStaticFontRegistryToUserFontRegistry(const WebKit::SandboxExtension::Handle& fontMachExtensionHandle) What is the point of changing this to an l-value? In general, handles should always be passed by r-value.
Per Arne Vollan
Comment 3 2021-07-29 11:02:33 PDT
Created attachment 434537 [details] Patch
Per Arne Vollan
Comment 4 2021-07-29 11:03:01 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 434521 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434521&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1282 > > +void WebProcess::switchFromStaticFontRegistryToUserFontRegistry(const WebKit::SandboxExtension::Handle& fontMachExtensionHandle) > > What is the point of changing this to an l-value? In general, handles should > always be passed by r-value. Ah, good point. I have reverted back to the previous signature. Thanks for reviewing!
Myles C. Maxfield
Comment 5 2021-07-29 11:45:07 PDT
Does this actually improve performance on OSes which have a static registry?
Per Arne Vollan
Comment 6 2021-07-29 12:04:47 PDT
(In reply to Myles C. Maxfield from comment #5) > Does this actually improve performance on OSes which have a static registry? Good point, I will start testing this now. Thanks for reviewing!
Darin Adler
Comment 7 2021-07-29 13:17:27 PDT
My review+ assumes that this works as expected and improves performance.
Per Arne Vollan
Comment 8 2021-07-29 13:30:42 PDT
(In reply to Darin Adler from comment #7) > My review+ assumes that this works as expected and improves performance. Will test performance before landing. Thanks for reviewing!
Alexey Proskuryakov
Comment 9 2021-07-31 18:12:10 PDT
*** Bug 228583 has been marked as a duplicate of this bug. ***
Per Arne Vollan
Comment 10 2021-08-02 09:56:37 PDT
(In reply to Per Arne Vollan from comment #8) > (In reply to Darin Adler from comment #7) > > My review+ assumes that this works as expected and improves performance. > > Will test performance before landing. > > Thanks for reviewing! Landing just the sandbox extension bits, since re-enabling the font pre-warming does not show a meaningful performance improvement.
Per Arne Vollan
Comment 11 2021-08-02 09:59:15 PDT
Created attachment 434765 [details] Patch
EWS
Comment 12 2021-08-02 10:29:12 PDT
Committed r280542 (240169@main): <https://commits.webkit.org/240169@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434765 [details].
Radar WebKit Bug Importer
Comment 13 2021-08-02 10:30:18 PDT
<rdar://problem/81418101>
Note You need to log in before you can comment on or make changes to this bug.