Bug 228574 - makeWeakPtr should support Ref and RefPtr as the argument
Summary: makeWeakPtr should support Ref and RefPtr as the argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-28 16:47 PDT by Ryosuke Niwa
Modified: 2021-07-28 19:34 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.66 KB, patch)
2021-07-28 16:51 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-07-28 16:47:17 PDT 
makeWeakPtr should support Ref and RefPtr as the argument
Comment 1 Ryosuke Niwa 2021-07-28 16:51:02 PDT 
Created attachment 434475 [details]
Patch
Comment 2 Wenson Hsieh 2021-07-28 16:56:25 PDT 
Comment on attachment 434475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434475&action=review

r=mews

> Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370
> +    Ref baseObject = BaseObjectWithRefAndWeakPtr::create();

Nit - auto?
Comment 3 Ryosuke Niwa 2021-07-28 17:26:47 PDT 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 434475 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434475&action=review
> 
> r=mews
> 
> > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370
> > +    Ref baseObject = BaseObjectWithRefAndWeakPtr::create();
> 
> Nit - auto?

Oh, I wanted to explicitly name Ref here since I have tests for RefPtr as well as Ref.
Comment 4 EWS 2021-07-28 19:33:14 PDT 
Committed r280414 (240054@main): <https://commits.webkit.org/240054@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434475 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-28 19:34:16 PDT 
<rdar://problem/81249177>