RESOLVED FIXED 228574
makeWeakPtr should support Ref and RefPtr as the argument 
https://bugs.webkit.org/show_bug.cgi?id=228574
Summary makeWeakPtr should support Ref and RefPtr as the argument
Ryosuke Niwa
Reported 2021-07-28 16:47:17 PDT
makeWeakPtr should support Ref and RefPtr as the argument
Attachments
Patch (8.66 KB, patch)
2021-07-28 16:51 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-07-28 16:51:02 PDT
Created attachment 434475 [details] Patch
Wenson Hsieh
Comment 2 2021-07-28 16:56:25 PDT
Comment on attachment 434475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434475&action=review r=mews > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370 > + Ref baseObject = BaseObjectWithRefAndWeakPtr::create(); Nit - auto?
Ryosuke Niwa
Comment 3 2021-07-28 17:26:47 PDT
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 434475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434475&action=review > > r=mews > > > Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370 > > + Ref baseObject = BaseObjectWithRefAndWeakPtr::create(); > > Nit - auto? Oh, I wanted to explicitly name Ref here since I have tests for RefPtr as well as Ref.
EWS
Comment 4 2021-07-28 19:33:14 PDT
Committed r280414 (240054@main): <https://commits.webkit.org/240054@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434475 [details].
Radar WebKit Bug Importer
Comment 5 2021-07-28 19:34:16 PDT
<rdar://problem/81249177>
Note You need to log in before you can comment on or make changes to this bug.