RESOLVED FIXED 228549
RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle 
https://bugs.webkit.org/show_bug.cgi?id=228549
Summary RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRo...
youenn fablet
Reported 2021-07-28 05:31:33 PDT
RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle
Attachments
Patch (2.78 KB, patch)
2021-07-28 05:42 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.92 KB, patch)
2021-07-28 23:52 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-07-28 05:31:42 PDT
<rdar://80608977>
Radar WebKit Bug Importer
Comment 2 2021-07-28 05:31:59 PDT
<rdar://problem/81212597>
youenn fablet
Comment 3 2021-07-28 05:42:47 PDT
Created attachment 434420 [details] Patch
Eric Carlson
Comment 4 2021-07-28 07:01:39 PDT
Comment on attachment 434420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434420&action=review > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:78 > + IntSize size = { (int)pixelWidth , (int)pixelHeight }; Nit: the local isn't strictly necessary.
youenn fablet
Comment 5 2021-07-28 23:52:14 PDT
Created attachment 434503 [details] Patch for landing
EWS
Comment 6 2021-07-29 04:22:06 PDT
Committed r280421 (240061@main): <https://commits.webkit.org/240061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434503 [details].
Note You need to log in before you can comment on or make changes to this bug.