Bug 228549 - RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle
Summary: RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-28 05:31 PDT by youenn fablet
Modified: 2021-07-29 04:22 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2021-07-28 05:42 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (2.92 KB, patch)
2021-07-28 23:52 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-07-28 05:31:33 PDT 
RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle
Comment 1 youenn fablet 2021-07-28 05:31:42 PDT 
<rdar://80608977>
Comment 2 Radar WebKit Bug Importer 2021-07-28 05:31:59 PDT 
<rdar://problem/81212597>
Comment 3 youenn fablet 2021-07-28 05:42:47 PDT 
Created attachment 434420 [details]
Patch
Comment 4 Eric Carlson 2021-07-28 07:01:39 PDT 
Comment on attachment 434420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434420&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:78
> +        IntSize size = { (int)pixelWidth , (int)pixelHeight };

Nit: the local isn't strictly necessary.
Comment 5 youenn fablet 2021-07-28 23:52:14 PDT 
Created attachment 434503 [details]
Patch for landing
Comment 6 EWS 2021-07-29 04:22:06 PDT 
Committed r280421 (240061@main): <https://commits.webkit.org/240061@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434503 [details].