Bug 22849 - Re-enable Wrec on 64-bit
Summary: Re-enable Wrec on 64-bit
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2008-12-13 22:49 PST by Gavin Barraclough
Modified: 2008-12-13 23:19 PST (History)
0 users

See Also:

The patch (2.66 KB, patch)
2008-12-13 22:50 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Now with new improved changelogy goodness! (3.46 KB, patch)
2008-12-13 22:57 PST, Gavin Barraclough
zwarich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-13 22:49:28 PST
(works non-debug since olliej's executable allocator).
Comment 1 Gavin Barraclough 2008-12-13 22:50:13 PST
Created attachment 26008 [details]
The patch
Comment 2 Gavin Barraclough 2008-12-13 22:57:05 PST
Created attachment 26009 [details]
Now with new improved changelogy goodness!
Comment 3 Cameron Zwarich (cpst) 2008-12-13 23:00:59 PST
Comment on attachment 26009 [details]
Now with new improved changelogy goodness!

r=me, although in your comment in this bug you made a typo -- Oliver's executable allocator makes it work in Debug. It always worked in Release because we could change the protection flags on TCMalloc's mmap calls.
Comment 4 Gavin Barraclough 2008-12-13 23:19:52 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/wtf/Platform.h
Transmitting file data ....
Committed revision 39287.