WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22848
Port the remainder of the JIT to use the MacroAssembler...
https://bugs.webkit.org/show_bug.cgi?id=22848
Summary
Port the remainder of the JIT to use the MacroAssembler...
Gavin Barraclough
Reported
2008-12-13 15:43:49 PST
... bar calling convention related code, and code implementing optimizations which can be disabled.
Attachments
The patch
(49.42 KB, patch)
2008-12-13 15:44 PST
,
Gavin Barraclough
zwarich
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2008-12-13 15:44:17 PST
Created
attachment 26007
[details]
The patch No perf impact.
Cameron Zwarich (cpst)
Comment 2
2008-12-13 15:49:46 PST
Comment on
attachment 26007
[details]
The patch You accidentally added trailing whitespace to MacroAssembler.h:183. The name 'mips' should be capitalized. The members of JITCodeRef should come after the constructors and should not have the m_ prefix. Other than that, r=me.
Gavin Barraclough
Comment 3
2008-12-13 16:21:54 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/bytecode/CodeBlock.cpp Sending JavaScriptCore/bytecode/CodeBlock.h Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITArithmetic.cpp Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITPropertyAccess.cpp Transmitting file data ........... Committed revision 39284.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug