Bug 22848 - Port the remainder of the JIT to use the MacroAssembler...
Summary: Port the remainder of the JIT to use the MacroAssembler...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2008-12-13 15:43 PST by Gavin Barraclough
Modified: 2008-12-13 16:21 PST (History)
0 users

See Also:

The patch (49.42 KB, patch)
2008-12-13 15:44 PST, Gavin Barraclough
zwarich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-13 15:43:49 PST
... bar calling convention related code, and code implementing optimizations which can be disabled.
Comment 1 Gavin Barraclough 2008-12-13 15:44:17 PST
Created attachment 26007 [details]
The patch

No perf impact.
Comment 2 Cameron Zwarich (cpst) 2008-12-13 15:49:46 PST
Comment on attachment 26007 [details]
The patch

You accidentally added trailing whitespace to MacroAssembler.h:183.

The name 'mips' should be capitalized.

The members of JITCodeRef should come after the constructors and should not have the m_ prefix.

Other than that, r=me.
Comment 3 Gavin Barraclough 2008-12-13 16:21:54 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/bytecode/CodeBlock.cpp
Sending        JavaScriptCore/bytecode/CodeBlock.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JIT.h
Sending        JavaScriptCore/jit/JITArithmetic.cpp
Sending        JavaScriptCore/jit/JITCall.cpp
Sending        JavaScriptCore/jit/JITInlineMethods.h
Sending        JavaScriptCore/jit/JITPropertyAccess.cpp
Transmitting file data ...........
Committed revision 39284.