WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22838
Remove dependency on the bytecode Instruction buffer in Interpreter::throwException
https://bugs.webkit.org/show_bug.cgi?id=22838
Summary
Remove dependency on the bytecode Instruction buffer in Interpreter::throwExc...
Sam Weinig
Reported
2008-12-12 19:12:52 PST
Interpreter:: throwException is one of the few remaining places where we require access to the bytecode Instruction buffer from JIT code. In order to purge the buffer after native code generation, we need to fix this. In order to accomplish this, we can probably store the required data in the CodeBlock when we recompile with profiling hooks.
Attachments
patch
(6.49 KB, patch)
2008-12-16 22:08 PST
,
Sam Weinig
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2008-12-12 19:13:24 PST
Related to <
rdar://problem/6428342
>
Sam Weinig
Comment 2
2008-12-16 22:08:50 PST
Created
attachment 26086
[details]
patch
Geoffrey Garen
Comment 3
2008-12-16 22:26:52 PST
Comment on
attachment 26086
[details]
patch +#if ENABLE(JIT) The #if is backwards. Next person who copies binary chop code instead of reusing gets a smack.
Sam Weinig
Comment 4
2008-12-16 22:30:32 PST
Fixed in
r39354
.
Darin Adler
Comment 5
2008-12-17 09:56:33 PST
(In reply to
comment #3
)
> Next person who copies binary chop code instead of reusing gets a smack.
We could possibly even use std::binary_search from <algorithm> rather than writing our own.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug