WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
228313
LayoutTestHelper does not correctly restore color profiles for some devices
https://bugs.webkit.org/show_bug.cgi?id=228313
Summary
LayoutTestHelper does not correctly restore color profiles for some devices
Cameron McCormack (:heycam)
Reported
2021-07-26 22:07:50 PDT
LayoutTestHelper only looks for profiles named "1", which is a default profile name. Some devices have multiple profile names, such as my external monitor, which has this device info dictionary: (lldb) po deviceInfo { CustomProfiles = { "HDMI HD" = "file:///System/Library/ColorSync/Profiles/sRGB%20Profile.icc"; }; DeviceClass = mntr; DeviceDescription = "ASUS PB27U"; DeviceHostScope = kCFPreferencesCurrentHost; DeviceID = "<CFUUID 0x6000037cc3e0> 4261DDFA-A1B4-1E80-AD62-026351A927F0"; DeviceUserScope = kCFPreferencesAnyUser; FactoryProfiles = { DeviceDefaultProfileID = "HDMI HD"; "HDMI HD" = { DeviceModeDescription = "HDMI HD"; DeviceProfileURL = "file:///Library/ColorSync/Profiles/Displays/ASUS%20PB27U-4261DDFA-A1B4-1E80-AD62-026351A927F0.icc"; }; "HDMI SD" = { DeviceModeDescription = "HDMI SD"; DeviceProfileURL = "file:///System/Library/CoreServices/Resources/Profiles/SD%20170M-A.icc"; }; }; } We should look at the DeviceDefaultProfileID and use that as the profile name.
Attachments
Patch
(3.44 KB, patch)
2021-07-26 22:34 PDT
,
Cameron McCormack (:heycam)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1
2021-07-26 22:10:51 PDT
s/profile name/mode/, maybe.
Radar WebKit Bug Importer
Comment 2
2021-07-26 22:11:04 PDT
<
rdar://problem/81146417
>
Cameron McCormack (:heycam)
Comment 3
2021-07-26 22:34:38 PDT
Created
attachment 434270
[details]
Patch
EWS
Comment 4
2021-08-10 16:51:46 PDT
Committed
r280871
(
240410@main
): <
https://commits.webkit.org/240410@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 434270
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug