Bug 228313 – LayoutTestHelper does not correctly restore color profiles for some devices

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Cameron McCormack (:heycam)]

LayoutTestHelper only looks for profiles named "1", which is a default profile name.  Some devices have multiple profile names, such as my external monitor, which has this device info dictionary:

(lldb) po deviceInfo
{
    CustomProfiles =     {
        "HDMI HD" = "file:///System/Library/ColorSync/Profiles/sRGB%20Profile.icc";
    };
    DeviceClass = mntr;
    DeviceDescription = "ASUS PB27U";
    DeviceHostScope = kCFPreferencesCurrentHost;
    DeviceID = "<CFUUID 0x6000037cc3e0> 4261DDFA-A1B4-1E80-AD62-026351A927F0";
    DeviceUserScope = kCFPreferencesAnyUser;
    FactoryProfiles =     {
        DeviceDefaultProfileID = "HDMI HD";
        "HDMI HD" =         {
            DeviceModeDescription = "HDMI HD";
            DeviceProfileURL = "file:///Library/ColorSync/Profiles/Displays/ASUS%20PB27U-4261DDFA-A1B4-1E80-AD62-026351A927F0.icc";
        };
        "HDMI SD" =         {
            DeviceModeDescription = "HDMI SD";
            DeviceProfileURL = "file:///System/Library/CoreServices/Resources/Profiles/SD%20170M-A.icc";
        };
    };
}

We should look at the DeviceDefaultProfileID and use that as the profile name.

[Cameron McCormack (:heycam)]

s/profile name/mode/, maybe.

[Radar WebKit Bug Importer]

<rdar://problem/81146417>

[Cameron McCormack (:heycam)]

Created attachment 434270 [details]
Patch

[EWS]

Committed r280871 (240410@main): <https://commits.webkit.org/240410@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434270 [details].