Bug 228310 – [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Devin Rousso]

# STEPS TO REPRODUCE
1. go to any page with a `<video>`
2. click the >> overflow button
3. dismiss the contextmenu (e.g. click outside, escape, etc.)

# EXPECTED
the >> overflow button would no longer be white

# ACTUAL
the >> overflow button is still white

[Devin Rousso]

<rdar://problem/81124786>

[Devin Rousso]

Created attachment 434260 [details]
Patch

[Wenson Hsieh]

Comment on attachment 434260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review

> Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:71
> +    m_page->shouldWaitForContextMenuToShow();

Nit - `shouldWaitForContextMenuToShow()` sounds a bit like the name of a const getter. Perhaps something along the lines of `startWaitingForContextMenuToShow()`?

[Eric Carlson]

Comment on attachment 434260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review

> Source/WebCore/ChangeLog:21
> +        as that's the signal to the `MediaController` that the contextmenu interaction is ove, which

s/ove/over/

[Devin Rousso]

Created attachment 434303 [details]
Patch

[Devin Rousso]

Created attachment 434305 [details]
Patch

oops forgot new test files

[Devin Rousso]

Created attachment 434315 [details]
Patch

fix test expectations

[EWS]

Committed r280374 (240018@main): <https://commits.webkit.org/240018@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434315 [details].