Bug 228294 - Attribution context causes some performance regressions
Summary: Attribution context causes some performance regressions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-26 12:33 PDT by Kate Cheney
Modified: 2021-07-26 15:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2021-07-26 12:34 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch for landing (1.61 KB, patch)
2021-07-26 14:30 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-07-26 12:33:21 PDT 
Attribution context causes some performance regressions
Comment 1 Kate Cheney 2021-07-26 12:34:16 PDT 
Created attachment 434225 [details]
Patch
Comment 2 Per Arne Vollan 2021-07-26 12:45:54 PDT 
Comment on attachment 434225 [details]
Patch

R=me.
Comment 3 EWS 2021-07-26 13:40:16 PDT 
Committed r280311 (239961@main): <https://commits.webkit.org/239961@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434225 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-26 13:41:16 PDT 
<rdar://problem/81127864>
Comment 5 Darin Adler 2021-07-26 14:21:22 PDT 
Comment on attachment 434225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434225&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61
>  static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
> +static void overrideAttributionContext(NSMutableURLRequest *) { };

These semicolons should not be here.
Comment 6 Kate Cheney 2021-07-26 14:30:50 PDT 
Reopening to attach new patch.
Comment 7 Kate Cheney 2021-07-26 14:30:52 PDT 
Created attachment 434241 [details]
Patch for landing
Comment 8 EWS 2021-07-26 14:59:22 PDT 
Committed r280317 (239965@main): <https://commits.webkit.org/239965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434241 [details].
Comment 9 Kate Cheney 2021-07-26 15:00:20 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 434225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=434225&action=review
> 
> > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61
> >  static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { };
> > +static void overrideAttributionContext(NSMutableURLRequest *) { };
> 
> These semicolons should not be here.

Thanks, fixed it in a followup.