Bug 228286 - WebXRSession::m_visibilityState is uninitialized
Summary: WebXRSession::m_visibilityState is uninitialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-26 11:10 PDT by Ada Chan
Modified: 2021-07-26 12:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (611 bytes, patch)
2021-07-26 11:12 PDT, Ada Chan 		sam: review-
Details | Formatted Diff | Diff
Patch (1.24 KB, patch)
2021-07-26 11:24 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-07-26 11:10:23 PDT 
WebXRSession::m_visibilityState is uninitialized.
It should be initialized to XRVisibilityState::VISIBLE.
Comment 1 Ada Chan 2021-07-26 11:12:35 PDT 
Created attachment 434217 [details]
Patch
Comment 2 Sam Weinig 2021-07-26 11:15:31 PDT 
Comment on attachment 434217 [details]
Patch

Change looks fine, but you are going to need a ChangeLog.
Comment 3 Ada Chan 2021-07-26 11:24:21 PDT 
Created attachment 434219 [details]
Patch
Comment 4 EWS 2021-07-26 12:22:52 PDT 
Committed r280307 (239957@main): <https://commits.webkit.org/239957@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434219 [details].
Comment 5 Radar WebKit Bug Importer 2021-07-26 12:24:32 PDT 
<rdar://problem/81124067>